Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: Disable NEON on armv7 android. #38413

Merged
merged 2 commits into from
Dec 19, 2016
Merged

rustc: Disable NEON on armv7 android. #38413

merged 2 commits into from
Dec 19, 2016

Commits on Dec 16, 2016

  1. rustc: Disable NEON on armv7 android. 

    We thought Google's ABI for arvm7 required neon, but it is
currently optional, perhaps because there is a significant
population of Tegra 2 devices still in use.

This turns off neon code generation outside #[target-feature]
blocks just like we do on armv7-unknown-linux-gnu, but unlike
most other armv7 targets. LLVM defaults to +neon for this target,
so an explicit disable is necessary.

See https://developer.android.com/ndk/guides/abis.html#v7a
for instruction set extension requirements.

Closes rust-lang#38402.
    @rillian
    rillian committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    e900f6c View commit details
    Browse the repository at this point in the history

  2. rustc: Link to Android ABI requirements. 

    Hopefully these references will be stable and provide guidance
when requirements change in the future.
    @rillian
    rillian committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    9e01f76 View commit details
    Browse the repository at this point in the history