Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the first sentence in slice::sort #39314

Merged
merged 1 commit into from Jan 28, 2017
Merged

Rewrite the first sentence in slice::sort #39314

merged 1 commit into from Jan 28, 2017

Commits on Jan 26, 2017

  1. Rewrite the first sentence in slice::sort 

    For every method, the first sentence should consisely explain what it does,
not how. This sentence usually starts with a verb.

It's really weird for `sort` to be explained in terms of another function,
namely `sort_by`. There's no need for that because it's obvious how `sort`
sorts elements: there is `T: Ord`.

If `sort_by_key` does not have to explicitly state how it's implemented,
then `sort` doesn't either.
    Stjepan Glavina committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    f02c9e3 View commit details
    Browse the repository at this point in the history