Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename other than copy/remove #39439

Merged
merged 3 commits into from
Feb 5, 2017
Merged

rename other than copy/remove #39439

merged 3 commits into from
Feb 5, 2017

Conversation

king6cong
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member

eddyb commented Feb 1, 2017

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned eddyb Feb 1, 2017
@alexcrichton
Copy link
Member

Thanks for the PR! Sometimes the rename operation can fail when a copy would otherwise succeed (such as crossing filesystems), perhaps that could be used first with a copy fallback?

@eddyb
Copy link
Member

eddyb commented Feb 1, 2017

@alexcrichton Is there no such "best effort" operation implemented anywhere, for moving files?

@alexcrichton
Copy link
Member

Oh there probably issue e.g. in the incremental support, I'm not familiar with the precise location, though (@michaelwoerister may know)

@michaelwoerister
Copy link
Member

Here is something:

pub fn link_or_copy<P: AsRef<Path>, Q: AsRef<Path>>(p: P, q: Q) -> io::Result<LinkOrCopy> {

It's not for renaming though but for copy vs hard-link.

@king6cong
Copy link
Contributor Author

Thanks for your advice, everyone 😺
Here's another commit. @alexcrichton

@alexcrichton
Copy link
Member

Looks good to me, thanks! I think the tidy check is failing on travis though?

@king6cong
Copy link
Contributor Author

File formatted @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 4, 2017

📌 Commit 5a21f42 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
bors added a commit that referenced this pull request Feb 5, 2017
Rollup of 12 pull requests

- Successful merges: #39439, #39472, #39481, #39491, #39501, #39509, #39514, #39519, #39526, #39528, #39530, #39538
- Failed merges:
@bors bors merged commit 5a21f42 into rust-lang:master Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants