-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename other than copy/remove #39439
Conversation
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Thanks for the PR! Sometimes the |
@alexcrichton Is there no such "best effort" operation implemented anywhere, for moving files? |
Oh there probably issue e.g. in the incremental support, I'm not familiar with the precise location, though (@michaelwoerister may know) |
Here is something: Line 67 in 24055d0
It's not for renaming though but for copy vs hard-link. |
Thanks for your advice, everyone 😺 |
Looks good to me, thanks! I think the tidy check is failing on travis though? |
File formatted @alexcrichton |
@bors: r+ |
📌 Commit 5a21f42 has been approved by |
rename other than copy/remove
rename other than copy/remove
rename other than copy/remove
No description provided.