Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static recursion test added to compile-fail test suite #39834

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

cseale
Copy link
Contributor

@cseale cseale commented Feb 15, 2017

Issue #39059
r? @est31

prev: &'static StaticDoubleLinked,
next: &'static StaticDoubleLinked,
data: i32,
head: bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trailing commas are more idiomatic

@@ -0,0 +1,48 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: current year

static L3: StaticDoubleLinked = StaticDoubleLinked{prev: &L2, next: &L1, data: 3, head: false};
//~^^^ ERROR recursive static (see issue #29719)
//~^^^^ ERROR recursive static (see issue #29719)
//~^^^^^ ERROR recursive static (see issue #29719)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: interleaving these errors with the code is more idiomatic

@jseyfried
Copy link
Contributor

@bors delegate=est31

@bors
Copy link
Contributor

bors commented Feb 15, 2017

✌️ @est31 can now approve this pull request

@cseale cseale force-pushed the feature-gate-static-recursion branch from fdf478a to cf20d8e Compare February 15, 2017 20:13
static L1: StaticDoubleLinked = StaticDoubleLinked{prev: &L3, next: &L2, data: 1, head: true};
//~^ ERROR recursive static (see issue #29719)
//~^^ ERROR recursive static (see issue #29719)
//~^^^ ERROR recursive static (see issue #29719)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work, and is not what @jseyfried meant. Just make one line of code, followed by one line of comment, then one line of code, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I figured, it's just that the problem here is that it complains that the issue is always at line 21, and it is expecting 3 errors, which is confusing to me. Any ideas on why that is happening

Copy link
Contributor Author

@cseale cseale Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this:

static L1: StaticDoubleLinked = StaticDoubleLinked{prev: &L3, next: &L2, data: 1, head: true};
//~^ ERROR recursive static (see issue #29719)
static L2: StaticDoubleLinked = StaticDoubleLinked{prev: &L1, next: &L3, data: 2, head: false};
//~^ ERROR recursive static (see issue #29719)
static L3: StaticDoubleLinked = StaticDoubleLinked{prev: &L2, next: &L1, data: 3, head: false};
//~^ ERROR recursive static (see issue #29719)

fails with this error:

unexpected errors (from JSON output): [
    Error {
        line_num: 21,
        kind: Some(
            Error
        ),
        msg: "21:1: 21:95: recursive static (see issue #29719)"
    },
    Error {
        line_num: 21,
        kind: Some(
            Error
        ),
        msg: "21:1: 21:95: recursive static (see issue #29719)"
    }
]

not found errors (from test file): [
    Error {
        line_num: 23,
        kind: Some(
            Error
        ),
        msg: "recursive static (see issue #29719)"
    },
    Error {
        line_num: 25,
        kind: Some(
            Error
        ),
        msg: "recursive static (see issue #29719)"
    }
]

Sorry, I probably should have led with this in the comments as opposed to making a dumb looking edit. I don't understand why line 21 throws 3 of the same error

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm seems its a bug or something. See, that's why we are adding these tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll approve it and then file a PR to fix the error message bug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool ^_^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm seems its more complicated than I thought. I think I'll let it be, its "only" a feature gate test. But I'll file an issue so that it doesn't get forgotten.

@est31
Copy link
Member

est31 commented Feb 15, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Feb 15, 2017

📌 Commit cf20d8e has been approved by est31

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 15, 2017
…n, r=est31

static recursion test added to compile-fail test suite

Issue rust-lang#39059
r? @est31
bors added a commit that referenced this pull request Feb 16, 2017
Rollup of 11 pull requests

- Successful merges: #39775, #39793, #39804, #39824, #39834, #39837, #39839, #39840, #39843, #39844, #39846
- Failed merges:
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 16, 2017
…n, r=est31

static recursion test added to compile-fail test suite

Issue rust-lang#39059
r? @est31
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 16, 2017
…n, r=est31

static recursion test added to compile-fail test suite

Issue rust-lang#39059
r? @est31
bors added a commit that referenced this pull request Feb 16, 2017
Rollup of 12 pull requests

- Successful merges: #39775, #39793, #39804, #39834, #39836, #39839, #39840, #39843, #39844, #39846, #39857, #39861
- Failed merges:
@bors bors merged commit cf20d8e into rust-lang:master Feb 16, 2017
@cseale cseale deleted the feature-gate-static-recursion branch February 16, 2017 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants