Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl RangeArgument for RangeInclusive and add appropriate tests #39936

Merged
merged 3 commits into from
Mar 1, 2017
Merged

impl RangeArgument for RangeInclusive and add appropriate tests #39936

merged 3 commits into from
Mar 1, 2017

Conversation

djzin
Copy link
Contributor

@djzin djzin commented Feb 18, 2017

Now that RangeArgument returns a Bound, the impl for RangeInclusive is natural to implement and all that's required are tests around it.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Oops sorry I think I missed this, apologies!

Nevertheless looks great, thank you!

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 28, 2017

📌 Commit 4338290 has been approved by alexcrichton

@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 28, 2017
@bors
Copy link
Contributor

bors commented Feb 28, 2017

⌛ Testing commit 4338290 with merge 44f0926...

@bors
Copy link
Contributor

bors commented Feb 28, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Feb 28, 2017 via email

@bors
Copy link
Contributor

bors commented Feb 28, 2017

⌛ Testing commit 4338290 with merge 1808b08...

@bors
Copy link
Contributor

bors commented Feb 28, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Feb 28, 2017 via email

@bors
Copy link
Contributor

bors commented Feb 28, 2017

⌛ Testing commit 4338290 with merge 91af879...

@bors
Copy link
Contributor

bors commented Feb 28, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Feb 28, 2017 via email

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 1, 2017
@frewsxcv
Rollup merge of rust-lang#39936 - djzin:inclusive_rangeargument, r=al…
43df65f 
…excrichton

impl RangeArgument for RangeInclusive and add appropriate tests

Now that `RangeArgument` returns a `Bound`, the impl for `RangeInclusive` is natural to implement and all that's required are tests around it.
@frewsxcv frewsxcv mentioned this pull request Mar 1, 2017
Merged
bors added a commit that referenced this pull request Mar 1, 2017
@bors
Auto merge of #40167 - frewsxcv:rollup, r=frewsxcv
88f7016 
Rollup of 6 pull requests

- Successful merges: #39419, #39936, #39944, #39960, #40028, #40128
- Failed merges:
bors added a commit that referenced this pull request Mar 1, 2017
@bors
Auto merge of #40167 - frewsxcv:rollup, r=frewsxcv
b671c32 
Rollup of 6 pull requests

- Successful merges: #39419, #39936, #39944, #39960, #40028, #40128
- Failed merges:
@bors
Copy link
Contributor

bors commented Mar 1, 2017

☔ The latest upstream changes (presumably #40167) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 4338290 into rust-lang:master Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djzin @rust-highfive @alexcrichton @bors