Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing url in sync structs #40081

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Add missing url in sync structs #40081

merged 1 commit into from
Mar 2, 2017

Conversation

GuillaumeGomez
Copy link
Member

@frewsxcv
Copy link
Member 

std/sync/struct.PoisonError.html:62: broken link fragment  `#method.lock` pointing to `std/sync/struct.RwLock.html`

std/sync/type.TryLockResult.html:54: broken link - std/sync/struct.LockResult.html

frewsxcv
frewsxcv reviewed Feb 28, 2017
View reviewed changes
src/libstd/sys_common/poison.rs
@@ -60,10 +60,13 @@ pub struct Guard {

/// A type of error which can be returned whenever a lock is acquired.
///
/// Both Mutexes and RwLocks are poisoned whenever a thread fails while the lock
/// Both [`Mutex`]es and [`RwLock`]s are poisoned whenever a thread fails while the lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you meant https://doc.rust-lang.org/std/sync/struct.Condvar.html#method.wait

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely!

@GuillaumeGomez
Copy link
Member Author

Updated.

@frewsxcv
Copy link
Member

frewsxcv commented Mar 2, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 2, 2017

📌 Commit 992dd20 has been approved by frewsxcv

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 2, 2017
@GuillaumeGomez
Rollup merge of rust-lang#40081 - GuillaumeGomez:poison-docs, r=frewsxcv
5d08775 
Add missing url in sync structs

r? @frewsxcv
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 2, 2017
Merged
bors added a commit that referenced this pull request Mar 2, 2017
@bors
Auto merge of #40206 - GuillaumeGomez:rollup, r=GuillaumeGomez
8ae411e 
Rollup of 9 pull requests

- Successful merges: #40081, #40144, #40168, #40169, #40170, #40173, #40175, #40191, #40194
- Failed merges:
@bors bors merged commit 992dd20 into rust-lang:master Mar 2, 2017
@GuillaumeGomez GuillaumeGomez deleted the poison-docs branch March 2, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv left review comments

Assignees

@frewsxcv frewsxcv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @frewsxcv @bors