-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 24 pull requests #40427
Rollup of 24 pull requests #40427
Commits on Feb 25, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 8a64cf7 - Browse repository at this point
Copy the full SHA 8a64cf7View commit details
Commits on Feb 28, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 53d3c89 - Browse repository at this point
Copy the full SHA 53d3c89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54a1c8b - Browse repository at this point
Copy the full SHA 54a1c8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a40918 - Browse repository at this point
Copy the full SHA 2a40918View commit details -
Configuration menu - View commit details
-
Copy full SHA for be49671 - Browse repository at this point
Copy the full SHA be49671View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90e94d9 - Browse repository at this point
Copy the full SHA 90e94d9View commit details
Commits on Mar 8, 2017
-
Fixes rendering of the end of the `Configure and Make` section.
Configuration menu - View commit details
-
Copy full SHA for 234753a - Browse repository at this point
Copy the full SHA 234753aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3198904 - Browse repository at this point
Copy the full SHA 3198904View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79a7ee8 - Browse repository at this point
Copy the full SHA 79a7ee8View commit details
Commits on Mar 9, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 74bc7fd - Browse repository at this point
Copy the full SHA 74bc7fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eeede3 - Browse repository at this point
Copy the full SHA 4eeede3View commit details -
Configuration menu - View commit details
-
Copy full SHA for da6e7c8 - Browse repository at this point
Copy the full SHA da6e7c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57c989c - Browse repository at this point
Copy the full SHA 57c989cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e2390f - Browse repository at this point
Copy the full SHA 3e2390fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8062cfb - Browse repository at this point
Copy the full SHA 8062cfbView commit details -
Do not bother creating StorageLive for TyNever
Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.
Configuration menu - View commit details
-
Copy full SHA for 84d1f6a - Browse repository at this point
Copy the full SHA 84d1f6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4078b25 - Browse repository at this point
Copy the full SHA 4078b25View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfb41ae - Browse repository at this point
Copy the full SHA cfb41aeView commit details -
gdb will now reliably detect the lanugage as rust even before any code is run.
Configuration menu - View commit details
-
Copy full SHA for b95b5db - Browse repository at this point
Copy the full SHA b95b5dbView commit details -
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr
Cengiz Can committedMar 9, 2017 Configuration menu - View commit details
-
Copy full SHA for 7f19f1f - Browse repository at this point
Copy the full SHA 7f19f1fView commit details
Commits on Mar 10, 2017
-
move related tests to type-check ui test directory
Cengiz Can committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 889337d - Browse repository at this point
Copy the full SHA 889337dView commit details -
travis: Attempt to debug sccache failures
I can't find anything that'd cause unexpected EOF in the source, so let's try taking a look at the error logs on failures.
Configuration menu - View commit details
-
Copy full SHA for a8cacd3 - Browse repository at this point
Copy the full SHA a8cacd3View commit details -
Don't put Cargo into the rustc workspace
This causes problems when first cloning and bootstrapping the repository unfortunately, so let's ensure that Cargo sticks around in its own workspace. Because Cargo is a submodule it's not available by default on the inital clone of the rust-lang/rust repository. Normally it's the responsibility of the rustbuild to take care of this, but unfortunately to build rustbuild itself we need to resolve the workspace conflicts. To deal with this we'll just have to ensure that all submodules are in their own workspace, which sort of makes sense anyway as updates to dependencies as bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any case this commit removes Cargo from the global workspace which should resolve the issues that we've been seeing. To actually perform this the `cargo` submodule has been moved to the top directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.
Configuration menu - View commit details
-
Copy full SHA for 7688222 - Browse repository at this point
Copy the full SHA 7688222View commit details -
Point to enclosing block/fn on nested unsafe
When declaring nested unsafe blocks (`unsafe {unsafe {}}`) that trigger the "unnecessary `unsafe` block" error, point out the enclosing `unsafe block` or `unsafe fn` that makes it unnecessary.
Configuration menu - View commit details
-
Copy full SHA for ac2bc7c - Browse repository at this point
Copy the full SHA ac2bc7cView commit details -
Export attributes in save-analysis data
Some annotations like the "test" annotations might be of interest for other projects, especially rls. Export all attributes in a new attributes item.
Configuration menu - View commit details
-
Copy full SHA for a07c9a2 - Browse repository at this point
Copy the full SHA a07c9a2View commit details -
Remove the AST structure
Configuration menu - View commit details
-
Copy full SHA for 203d227 - Browse repository at this point
Copy the full SHA 203d227View commit details -
Configuration menu - View commit details
-
Copy full SHA for db35604 - Browse repository at this point
Copy the full SHA db35604View commit details -
rustbuild: Build documentation for
proc_macro
This commit fixes rust-lang#38749 by building documentation for the `proc_macro` crate by default for configured hosts. Unfortunately did not turn out to be a trivial fix. Currently rustbuild generates documentation into multiple locations: one for std, one for test, and one for rustc. The initial fix for this issue simply actually executed `cargo doc -p proc_macro` which was otherwise completely elided before. Unfortunately rustbuild was the left to merge two documentation trees together. One for the standard library and one for the rustc tree (which only had docs for the `proc_macro` crate). Rustdoc itself knows how to merge documentation files (specifically around search indexes, etc) but rustbuild was unaware of this, so an initial fix ended up destroying the sidebar and the search bar from the libstd docs. To solve this issue the method of documentation has been tweaked slightly in rustbuild. The build system will not use symlinks (or directory junctions on Windows) to generate all documentation into the same location initially. This'll rely on rustdoc's logic to weave together all the output and ensure that it ends up all consistent. Closes rust-lang#38749
Configuration menu - View commit details
-
Copy full SHA for 2b5f1b2 - Browse repository at this point
Copy the full SHA 2b5f1b2View commit details -
Remove ability for plugins to register a MIR pass
In recent months there have been a few different people investigating how to make a plugin that registers a MIR-pass – one that isn’t intended to be eventually merged into rustc proper. The interface to register MIR passes was added primarily for miri (& later was found to make prototyping of rustc-proper MIR passes a tiny bit faster). Since miri does not use this interface anymore it seems like a good time to remove this "feature". For prototyping purposes a similar interface can be added by developers themselves in their custom rustc build.
Configuration menu - View commit details
-
Copy full SHA for 4ca9c97 - Browse repository at this point
Copy the full SHA 4ca9c97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b0dd7b - Browse repository at this point
Copy the full SHA 7b0dd7bView commit details -
rustc: Support auto-retry linking on a segfault
This is a last-ditch attempt to help our pain with dealing with rust-lang#38878 on the bots. A new environment variable is added to the compiler, `RUSTC_RETRY_LINKER_ON_SEGFAULT`, which will instruct the compiler to automatically retry the final linker invocation if it looks like the linker segfaulted (up to 2 extra times). Unfortunately there have been no successful attempts to debug rust-lang#38878. The only information seems to be that the linker (e.g. `ld` on OSX) is segfaulting somewhere in some thread pool implementation. This appears to be spurious as failed PRs will later merge. The hope is that this helps the queue keep moving without clogging and delaying PRs due to rust-lang#38878.
Configuration menu - View commit details
-
Copy full SHA for 993eae1 - Browse repository at this point
Copy the full SHA 993eae1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83814fd - Browse repository at this point
Copy the full SHA 83814fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 384ee48 - Browse repository at this point
Copy the full SHA 384ee48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 038ec50 - Browse repository at this point
Copy the full SHA 038ec50View commit details -
Rollup merge of rust-lang#39202 - estebank:nested-unsafe, r=jonathand…
…turner Point to enclosing block/fn on nested unsafe When declaring nested unsafe blocks (`unsafe {unsafe {}}`) that trigger the "unnecessary `unsafe` block" error, point out the enclosing `unsafe block` or `unsafe fn` that makes it unnecessary. <img width="621" alt="" src="https://cloud.githubusercontent.com/assets/1606434/22139922/26ad468a-de9e-11e6-8884-2945be882ea8.png"> Fixes rust-lang#39144.
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for d722bc8 - Browse repository at this point
Copy the full SHA d722bc8View commit details -
Rollup merge of rust-lang#39820 - jonasbb:export-attributes, r=nrc
Export attributes in save-analysis data Since this is my first pull-request to rust, I would like to get some feedback about obvious errors in this implementation. I would like to change the save-analysis data to include arbitrary attribute data. A use-case I have in mind for this is identifying functions with `#[test]` annotations such that tools like rls can offer a test-runner feature. I described my idea here [rls#173](rust-lang/rls#173). My changes contain: 1. track a vector of attributes in the various `*Data` types in `data.rs` and `external_data.rs` 2. implement lowering for `Attribute` and `MetaItem` 3. adjust `JsonDumper` to print the attributes In the lowering of `Attribute` I remove the distinction between `MetaItem` and `NestedMetaItem`. I did this because this distinction is somewhat confusing. For example, `NestedMetaItemKind::Literal` has two identical spans, because both `NestedMetaItem` and `Lit` are defined as `Spanned<_>`. My model is strictly more general, as it allows an `LitKind` instead of a `Symbol` for `MetaItem` and `Symbol`s are converted into a cooked string. As a consumer of the save-analysis data this shouldn't affect you much. Example json output of `#[test]` annotation: ``` "attributes": [ { "value": { "name": { "variant": "Str", "fields": [ "test", "Cooked" ] }, "kind": "Literal", "span": { "file_name": "test.rs", "byte_start": 2, "byte_end": 6, "line_start": 1, "line_end": 1, "column_start": 3, "column_end": 7 } }, "span": { "file_name": "test.rs", "byte_start": 0, "byte_end": 7, "line_start": 1, "line_end": 1, "column_start": 1, "column_end": 8 } } ] ```
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 70bb61b - Browse repository at this point
Copy the full SHA 70bb61bView commit details -
Rollup merge of rust-lang#40092 - sinkuu:fix_suggestion_index, r=pnkf…
…elix Fix suggestion span error with a line containing multibyte characters This PR fixes broken suggestions caused by multibyte characters. e.g. for this code, rustc provides a broken suggestion ([playground](https://is.gd/DWGLu7)): ```rust fn main() { let tup = (1,); println!("☃{}", tup[0]); } ``` ``` error: cannot index a value of type `({integer},)` --> <anon>:3:21 | 3 | println!("☃{}", tup[0]); | ^^^^^^ | help: to access tuple elements, use tuple indexing syntax as shown | println!("☃{}"tup.00]); error: aborting due to previous error ``` `CodeSuggestion::splice_lines` is misusing `Loc.col` (`CharPos`) as a byte offset when slicing source.
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 2866703 - Browse repository at this point
Copy the full SHA 2866703View commit details -
Rollup merge of rust-lang#40146 - bjorn3:few-infer-changes, r=pnkfelix
Better docs of rusty parts of typeck
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for fed96da - Browse repository at this point
Copy the full SHA fed96daView commit details -
Rollup merge of rust-lang#40199 - alexcrichton:doc-proc-macro, r=brson
rustbuild: Build documentation for `proc_macro` This commit fixes rust-lang#38749 by building documentation for the `proc_macro` crate by default for configured hosts. Unfortunately did not turn out to be a trivial fix. Currently rustbuild generates documentation into multiple locations: one for std, one for test, and one for rustc. The initial fix for this issue simply actually executed `cargo doc -p proc_macro` which was otherwise completely elided before. Unfortunately rustbuild was the left to merge two documentation trees together. One for the standard library and one for the rustc tree (which only had docs for the `proc_macro` crate). Rustdoc itself knows how to merge documentation files (specifically around search indexes, etc) but rustbuild was unaware of this, so an initial fix ended up destroying the sidebar and the search bar from the libstd docs. To solve this issue the method of documentation has been tweaked slightly in rustbuild. The build system will not use symlinks (or directory junctions on Windows) to generate all documentation into the same location initially. This'll rely on rustdoc's logic to weave together all the output and ensure that it ends up all consistent. Closes rust-lang#38749
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for a6b900d - Browse repository at this point
Copy the full SHA a6b900dView commit details -
Rollup merge of rust-lang#40225 - shepmaster:restore-build-date-file,…
… r=alexcrichton Restore creating the channel-rust-$channel-date.txt files I have **not** run this (because I don't know how to 😇), but it *does* compile. r? @alexcrichton
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 00f2281 - Browse repository at this point
Copy the full SHA 00f2281View commit details -
Rollup merge of rust-lang#40239 - nagisa:death-to-plugins, r=nikomats…
…akis Remove ability for plugins to register a MIR pass In recent months there have been a few different people investigating how to make a plugin that registers a MIR-pass – one that isn’t intended to be eventually merged into rustc proper. The interface to register MIR passes was added primarily for miri (& later was found to make prototyping of rustc-proper MIR passes a tiny bit faster). Since miri does not use this interface anymore it seems like a good time to remove this "feature". For prototyping purposes a similar interface can be added by developers themselves in their custom rustc build. cc @nikomatsakis
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 8a59355 - Browse repository at this point
Copy the full SHA 8a59355View commit details -
Rollup merge of rust-lang#40259 - TimNN:fix-emscripten-tests, r=alexc…
…richton Fix emscripten test detection Without this change `rustbuild` will attempt to run `.js.map` files (if they exist) resulting in lots of sadness. r? @alexcrichton
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 8f3c1d2 - Browse repository at this point
Copy the full SHA 8f3c1d2View commit details -
Rollup merge of rust-lang#40278 - GuillaumeGomez:css-cleanup, r=frewsxcv
Clean up rustdoc css r? @rust-lang/docs
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 57c5b54 - Browse repository at this point
Copy the full SHA 57c5b54View commit details -
Rollup merge of rust-lang#40287 - estebank:label-overlap, r=nrc
Fix incorrect span label formatting Fix rust-lang#40157.
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 57a9863 - Browse repository at this point
Copy the full SHA 57a9863View commit details -
Rollup merge of rust-lang#40297 - alexcrichton:fix-submodules, r=brson
Don't put Cargo into the rustc workspace This causes problems when first cloning and bootstrapping the repository unfortunately, so let's ensure that Cargo sticks around in its own workspace. Because Cargo is a submodule it's not available by default on the inital clone of the rust-lang/rust repository. Normally it's the responsibility of the rustbuild to take care of this, but unfortunately to build rustbuild itself we need to resolve the workspace conflicts. To deal with this we'll just have to ensure that all submodules are in their own workspace, which sort of makes sense anyway as updates to dependencies as bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any case this commit removes Cargo from the global workspace which should resolve the issues that we've been seeing. To actually perform this the `cargo` submodule has been moved to a new `vendor` directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace. Closes rust-lang#40284
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 699ec59 - Browse repository at this point
Copy the full SHA 699ec59View commit details -
Rollup merge of rust-lang#40319 - eddyb:it's-"unsize"-not-"unsound", …
…r=nikomatsakis Disallow subtyping between T and U in T: Unsize<U>. Because `&mut T` can be coerced to `&mut U`, `T` and `U` must be unified invariantly. Fixes rust-lang#40288. E.g. coercing `&mut [&'a X; N]` to `&mut [&'b X]` must require `'a` be equal to `'b`, otherwise you can convert between `&'a X` and `&'b X` (in either direction), potentially unsoundly lengthening lifetimes. Subtyping here was introduced with `Unsize` in rust-lang#24619 (landed in 1.1, original PR is rust-lang#23785).
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 34261e2 - Browse repository at this point
Copy the full SHA 34261e2View commit details -
Rollup merge of rust-lang#40324 - alexcrichton:sccache-errors, r=aturon
travis: Attempt to debug sccache failures I can't find anything that'd cause unexpected EOF in the source, so let's try taking a look at the error logs on failures.
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 17f06df - Browse repository at this point
Copy the full SHA 17f06dfView commit details -
Rollup merge of rust-lang#40345 - Nashenas88:patch-1, r=estebank
Fix missing backtick typo Fixes rendering of the end of the `Configure and Make` section.
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for bdbb229 - Browse repository at this point
Copy the full SHA bdbb229View commit details -
Rollup merge of rust-lang#40372 - nagisa:never-drop, r=eddyb
Do not bother creating StorageLive for TyNever Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway. r? @eddyb
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for bb8c054 - Browse repository at this point
Copy the full SHA bb8c054View commit details -
Rollup merge of rust-lang#40373 - TimNN:test-ub-packed, r=arielb1
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for f9ed95a - Browse repository at this point
Copy the full SHA f9ed95aView commit details -
Rollup merge of rust-lang#40385 - arielb1:packed-again, r=eddyb
emit !align attributes on stores of operand pairs This avoids another case of missing-align UB. cc rust-lang#40373 r? @eddyb
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 41bd4ad - Browse repository at this point
Copy the full SHA 41bd4adView commit details -
Rollup merge of rust-lang#40386 - tbu-:pr_display_frombyteswithnulerr…
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for f1cd2f2 - Browse repository at this point
Copy the full SHA f1cd2f2View commit details -
Rollup merge of rust-lang#40389 - F001:placementVecDeque, r=nagisa
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 1b81660 - Browse repository at this point
Copy the full SHA 1b81660View commit details -
Rollup merge of rust-lang#40400 - TimNN:gdbr-updates, r=alexcrichton
Update gdbr tests gdb will now reliably detect the lanugage as rust even before any code is run.
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for af60d7c - Browse repository at this point
Copy the full SHA af60d7cView commit details -
Rollup merge of rust-lang#40404 - cengizIO:master, r=nikomatsakis
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr Hello! This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory. Thanks to @nikomatsakis and @eddyb
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 7983978 - Browse repository at this point
Copy the full SHA 7983978View commit details -
Rollup merge of rust-lang#40410 - clarcharr:os_string_shrink_to_fit, …
…r=alexcrichton OsString::shrink_to_fit. Considering how the other capacity-related methods are there, I found it odd that this one wasn't included. Will create a tracking issue once I get an OK on this.
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 1ba54a7 - Browse repository at this point
Copy the full SHA 1ba54a7View commit details -
Rollup merge of rust-lang#40422 - alexcrichton:retry-linker-segfault,…
… r=arielb1 rustc: Support auto-retry linking on a segfault This is a last-ditch attempt to help our pain with dealing with rust-lang#38878 on the bots. A new environment variable is added to the compiler, `RUSTC_RETRY_LINKER_ON_SEGFAULT`, which will instruct the compiler to automatically retry the final linker invocation if it looks like the linker segfaulted (up to 2 extra times). Unfortunately there have been no successful attempts to debug rust-lang#38878. The only information seems to be that the linker (e.g. `ld` on OSX) is segfaulting somewhere in some thread pool implementation. This appears to be spurious as failed PRs will later merge. The hope is that this helps the queue keep moving without clogging and delaying PRs due to rust-lang#38878.
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 4e60835 - Browse repository at this point
Copy the full SHA 4e60835View commit details -
Rollup merge of rust-lang#40423 - DirkyJerky:patch-2, r=BurntSushi
Clarify docs in `VecDeque::resize`
Ariel Ben-Yehuda committedMar 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 10e12ea - Browse repository at this point
Copy the full SHA 10e12eaView commit details