Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"on-demandify" privacy and access levels #40771

Merged
merged 3 commits into from
Mar 26, 2017
Merged

"on-demandify" privacy and access levels #40771

merged 3 commits into from
Mar 26, 2017

Commits on Mar 23, 2017

  1. move export_map into the tcx

    @nikomatsakis
    nikomatsakis committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    a3a5ff9 View commit details
    Browse the repository at this point in the history

  2. ignore reads of tracked state when there is no current task 

    I realized that, even in the current system, such reads can't really do
any harm. Because they are not part of a task, they will occur no matter
what (only tasks can be skipped). If you leak the data you read into a
task, that is bad, but that is equally bad if you are in a task.

*Writes* to tracked state, on the other hand, should never occur except
from within a task (and the task then records what things you read to
compute it).

Once we complete the shift to on-demand, these properties will hold by
construction (because the on-demand struct enforces stateless tasks
where leaks are impossible -- except by having shared mutable state in
the tcx).
    @nikomatsakis
    nikomatsakis committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    69c9d9b View commit details
    Browse the repository at this point in the history

  3. convert privacy access levels into a query

    @nikomatsakis
    nikomatsakis committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    a9f6bab View commit details
    Browse the repository at this point in the history