Increase macro recursion limit to 1024 #41676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
If you add |
sirideain
changed the title
arielb1
added
the
S-waiting-on-review
|
r? @jseyfried |
sirideain
changed the title
|
Pinged @jseyfried on IRC for a review. |
jseyfried
approved these changes
May 7, 2017
|
@bors r+ |
|
📌 Commit 3008f53 has been approved by |
Mark-Simulacrum
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 7, 2017
…fried Increase macro recursion limit to 1024 Fixes #22552
|
☀️ Test successful - status-appveyor, status-travis |
Marwes
added a commit
to Marwes/gluon
that referenced
this pull request
Jun 25, 2017
Lets the large `record!` macro in primitives work. 1024 was chosen since that will be standard in rustc soon rust-lang/rust#41676
Marwes
added a commit
to Marwes/gluon
that referenced
this pull request
Jul 1, 2017
Lets the large `record!` macro in primitives work. 1024 was chosen since that will be standard in rustc soon rust-lang/rust#41676
Marwes
added a commit
to Marwes/gluon
that referenced
this pull request
Jul 1, 2017
Lets the large `record!` macro in primitives work. 1024 was chosen since that will be standard in rustc soon rust-lang/rust#41676
killercup
added a commit
to killercup/diesel
that referenced
this pull request
Aug 5, 2017
The attribute in `schema.rs` didn't seem to do anything. I'm not sure if that is a regression in Rust or an oversight on our part (and the attr wasn't necessary before). Additionally, looking at <rust-lang/rust#41676>, this shouldn't be necessary at all in recent nightlies (after May 7), but without the explicit setting, it fails to compile and suggests adding `#![recursion_limit="128"]`. If I read the code in [1] correctly, this means it was set to 64 before. [1]: https://github.com/rust-lang/rust/blob/5c7add7551fa093f655e76650a48564ac347c83a/src/librustc/traits/error_reporting.rs#L1150-L1156
Marwes
added a commit
to Marwes/gluon
that referenced
this pull request
Aug 5, 2017
Lets the large `record!` macro in primitives work. 1024 was chosen since that will be standard in rustc soon rust-lang/rust#41676
killercup
added a commit
to killercup/diesel
that referenced
this pull request
Aug 19, 2017
The attribute in `schema.rs` didn't seem to do anything. I'm not sure if that is a regression in Rust or an oversight on our part (and the attr wasn't necessary before). Additionally, looking at <rust-lang/rust#41676>, this shouldn't be necessary at all in recent nightlies (after May 7), but without the explicit setting, it fails to compile and suggests adding `#![recursion_limit="128"]`. If I read the code in [1] correctly, this means it was set to 64 before. [1]: https://github.com/rust-lang/rust/blob/5c7add7551fa093f655e76650a48564ac347c83a/src/librustc/traits/error_reporting.rs#L1150-L1156
|
Has this shipped? I'm still getting errors saying I need to increase the recursion limit to 128 when using the latest nightly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22552