Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing links for CStr and CString #42152

Merged
merged 1 commit into from
May 23, 2017
Merged

Add missing links for CStr and CString #42152

merged 1 commit into from
May 23, 2017

Conversation

GuillaumeGomez
Copy link
Member

r? @rust-lang/docs

@carols10cents
Copy link
Member

r? @steveklabnik

There's a known issue with highfive that asking a team to review doesn't work :-/

@carols10cents
Copy link
Member

Also looks like the linkchecker is failing?

[00:41:38] Linkcheck (x86_64-unknown-linux-gnu)
[00:41:41] std/ffi/index.html:73: broken link - std/ffi/struct.CStr
[00:41:41] std/ffi/index.html:81: broken link - std/ffi/struct.CString
[00:41:41] std/ffi/index.html:89: broken link - std/ffi/struct.CString
[00:41:41] std/ffi/struct.FromBytesWithNulError.html:52: broken link - std/ffi/struct.CStr
[00:41:41] std/ffi/struct.NulError.html:52: broken link - std/ffi/struct.CString
[00:41:41] std/ffi/struct.IntoStringError.html:52: broken link - std/ffi/struct.CString
[00:41:43] thread 'main' panicked at 'found some broken links', /checkout/src/tools/linkchecker/main.rs:49
[00:41:43] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:41:43] 
[00:41:43] 
[00:41:43] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[00:41:43] expected success, got: exit code: 101

@carols10cents carols10cents added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 22, 2017
@GuillaumeGomez
Copy link
Member Author

It was to be expected. Fixing it (well, trying to at least!).

@frewsxcv
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 23, 2017

📌 Commit 819acb5 has been approved by frewsxcv

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 23, 2017
@frewsxcv
Rollup merge of rust-lang#42152 - GuillaumeGomez:cstr-docs, r=frewsxcv
2cc6839 
Add missing links for CStr and CString

r? @rust-lang/docs
@frewsxcv frewsxcv mentioned this pull request May 23, 2017
Merged
bors added a commit that referenced this pull request May 23, 2017
@bors
Auto merge of #42165 - frewsxcv:rollup, r=frewsxcv
852b7cb 
Rollup of 8 pull requests

- Successful merges: #42016, #42122, #42144, #42145, #42151, #42152, #42160, #42163
- Failed merges:
@bors bors merged commit 819acb5 into rust-lang:master May 23, 2017
@GuillaumeGomez GuillaumeGomez deleted the cstr-docs branch May 23, 2017 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @carols10cents @frewsxcv @bors @steveklabnik