-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade LLVM #42410
Upgrade LLVM #42410
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Travis seems to have failed on the newly introduced test. Perhaps it needs to be marked with the llvm greater than marker? https://travis-ci.org/rust-lang/rust/jobs/239126530#L1086 |
Technically, it needs a marker for local-vs-system LLVM. I’ll think about it. |
@nagisa Don't we have something like that already? cc @alexcrichton |
@eddyb I can only see instances of |
I don't believe we have one already, but it shouldn't be hard to add |
@nagisa Could you consider upgrading to 84c52ce which has my changes in too, to fix ARMv6-M |
Includes rust-lang/llvm#80 Includes rust-lang/llvm#79 Also adds tests and thus fixes rust-lang#24194
This is ready, I think. |
@bors r+ |
📌 Commit 7d251d8 has been approved by |
⌛ Testing commit 7d251d8 with merge 2c3b65c... |
💔 Test failed - status-travis |
Legitimate failure.
|
@bors r=sanxiyn |
📌 Commit 3d15d79 has been approved by |
⌛ Testing commit 3d15d79 with merge f3c9977... |
💔 Test failed - status-travis |
@bors r- never mind
are the real failures. |
I cannot reproduce the failures locally. The failure looks super weird to me though. I have a bunch ideas where the problem could be, but with homu being the only way to reproduce the issue it is super hard to try them out. |
Ok, the issue is exactly where I expected it to be – allocate_zeroed. Too bad that I cannot make it work no matter what I do (I’ve tried both making it a I’m not gonna investigate the exact cause of the bug; we can live without optimisation for allocate_zeroed IMO. |
@bors r=sanxiyn |
📌 Commit 7aaa22c has been approved by |
⌛ Testing commit 7aaa22c with merge f520e36... |
💔 Test failed - status-travis |
Seems legit |
@bors r=sanxiyn |
📌 Commit 406eddf has been approved by |
⌛ Testing commit 406eddf with merge 885d0f8... |
💔 Test failed - status-travis |
Timeout on i686? @bors retry |
Upgrade LLVM Includes rust-lang/llvm#80
☀️ Test successful - status-appveyor, status-travis |
Includes rust-lang/llvm#80