Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bootstrapping with custom cargo/rustc. #42785

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

Mark-Simulacrum
Copy link
Member

config.mk is now always read when parsing the configuration to prevent
this from reoccurring in the future, hopefully.

Fixes #42543.

r? @alexcrichton

cc @infinity0 @kyrias

config.mk is now always read when parsing the configuration to prevent
this from reoccurring in the future, hopefully.
@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 21, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 21, 2017

📌 Commit 4caa0b0 has been approved by alexcrichton

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 21, 2017
@infinity0
Copy link
Contributor

Thanks, this together with #42695 backported to 1.18 fixes #42543 over here on Debian.

@kyrias
Copy link
Contributor

kyrias commented Jun 21, 2017

Affirmative, the patches fixes the problem for me as well.

@Mark-Simulacrum
Copy link
Member Author

@bors rollup

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 22, 2017
…ap, r=alexcrichton

Fixes bootstrapping with custom cargo/rustc.

config.mk is now always read when parsing the configuration to prevent
this from reoccurring in the future, hopefully.

Fixes rust-lang#42543.

r? @alexcrichton

cc @infinity0 @kyrias
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 22, 2017
…ap, r=alexcrichton

Fixes bootstrapping with custom cargo/rustc.

config.mk is now always read when parsing the configuration to prevent
this from reoccurring in the future, hopefully.

Fixes rust-lang#42543.

r? @alexcrichton

cc @infinity0 @kyrias
@bors
Copy link
Contributor

bors commented Jun 22, 2017

⌛ Testing commit 4caa0b0 with merge efdf55d...

bors added a commit that referenced this pull request Jun 22, 2017
…richton

Fixes bootstrapping with custom cargo/rustc.

config.mk is now always read when parsing the configuration to prevent
this from reoccurring in the future, hopefully.

Fixes #42543.

r? @alexcrichton

cc @infinity0 @kyrias
@bors
Copy link
Contributor

bors commented Jun 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing efdf55d to master...

@bors bors merged commit 4caa0b0 into rust-lang:master Jun 22, 2017
@brson brson mentioned this pull request Jun 22, 2017
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 22, 2017
bors added a commit that referenced this pull request Jun 25, 2017
[beta] backports

- #42785
- #42740
- #42735
- #42728
- #42695
- #42659
- #42634
- #42566

I just unilaterally accepted all the non-accepted nominations. Everything picked cleanly.

Still testing locally.

cc @rust-lang/compiler

r? @alexcrichton
bors added a commit that referenced this pull request Jun 25, 2017
[beta] backports

- #42785
- #42740
- #42735
- #42728
- #42695
- #42659
- #42634
- #42566

I just unilaterally accepted all the non-accepted nominations. Everything picked cleanly.

Still testing locally.

cc @rust-lang/compiler

r? @alexcrichton
bors added a commit that referenced this pull request Jun 27, 2017
[beta] backports

Reopening #42841 as a new PR due to bors flakiness.

- #42785
- #42740
- #42735
- #42728
- #42695
- #42659
- #42634
- #42566

I just unilaterally accepted all the non-accepted nominations. Everything picked cleanly.
bors added a commit that referenced this pull request Jun 27, 2017
[beta] backports

Reopening #42841 as a new PR due to bors flakiness.

- #42785
- #42740
- #42735
- #42728
- #42695
- #42659
- #42634
- #42566

I just unilaterally accepted all the non-accepted nominations. Everything picked cleanly.
@Mark-Simulacrum Mark-Simulacrum deleted the fix-verbose-bootstrap branch June 8, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants