-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap: remove unneeded extern crate #44121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crate itself is internally referenced by serde_derive.
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ rollup |
📌 Commit 45d31ac has been approved by |
arielb1
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Aug 28, 2017
I think we want this on 1.21 too - if #42588 makes the cut to 1.21. |
carols10cents
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 28, 2017
⌛ Testing commit 45d31ac with merge 1d8b0c548dcd8453ed077d6ba4bc251cb0188c45... |
I'm marking as beta-approved. Doesn't necessarily need to be backported, but wouldn't hurt. |
Mark-Simulacrum
added
the
beta-accepted
Accepted for backporting to the compiler in the beta channel.
label
Aug 28, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
alexcrichton
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crate itself is internally referenced by serde_derive.