Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend E0623 for earlybound and latebound for structs #44549

Merged
merged 5 commits into from
Sep 17, 2017

Conversation

gaurikholkar-zz
Copy link

@gaurikholkar-zz gaurikholkar-zz commented Sep 13, 2017

This fixes #44508

r? @nikomatsakis

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@gaurikholkar-zz
Copy link
Author

cc @arielb1

@arielb1
Copy link
Contributor

arielb1 commented Sep 13, 2017

test please

// the lifetime of the TyPath!
Some(rl::Region::LateBoundAnon(debruijn_index, anon_index)) => {
(Some(rl::Region::LateBoundAnon(debruijn_index, anon_index)), ty::BrAnon(br_index)) => {
if debruijn_index.depth == 1 && anon_index == br_index {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still doing the wrong thing with LBRs. Please compare against the correct deBruijn index.

Copy link
Contributor

@nikomatsakis nikomatsakis Sep 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's #44516...right?

Copy link
Contributor

@arielb1 arielb1 Sep 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not fixed by #44516, and is new code.

debug!("self.infcx.tcx.hir.local_def_id(id)={:?}",
self.infcx.tcx.hir.local_def_id(id));
debug!("def_id={:?}", def_id);
if debruijn_index.depth == 1 && self.infcx.tcx.hir.local_def_id(id) == def_id {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

@aidanhs aidanhs added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 13, 2017
@gaurikholkar-zz
Copy link
Author

@arielb1 updated

@gaurikholkar-zz
Copy link
Author

I'm guessing this is complete. Let me know if anything more is needed @nikomatsakis @arielb1

@arielb1
Copy link
Contributor

arielb1 commented Sep 14, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Sep 14, 2017

📌 Commit 9240454 has been approved by arielb1

Removing unwanted file merged in  a previous commit
@gaurikholkar-zz
Copy link
Author

@arielb1 can you approve again

@arielb1
Copy link
Contributor

arielb1 commented Sep 14, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Sep 14, 2017

📌 Commit 5229443 has been approved by arielb1

@alexcrichton
Copy link
Member

@bors: rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 16, 2017
extend E0623 for earlybound and latebound for structs

This fixes rust-lang#44508

r? @nikomatsakis
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 16, 2017
extend E0623 for earlybound and latebound for structs

This fixes rust-lang#44508

r? @nikomatsakis
TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
extend E0623 for earlybound and latebound for structs

This fixes rust-lang#44508

r? @nikomatsakis
TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
extend E0623 for earlybound and latebound for structs

This fixes rust-lang#44508

r? @nikomatsakis
TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
extend E0623 for earlybound and latebound for structs

This fixes rust-lang#44508

r? @nikomatsakis
bors added a commit that referenced this pull request Sep 17, 2017
Rollup of 17 pull requests

- Successful merges: #44073, #44088, #44381, #44397, #44509, #44533, #44549, #44553, #44562, #44567, #44595, #44604, #44617, #44622, #44630, #44639, #44647
- Failed merges:
@bors
Copy link
Contributor

bors commented Sep 17, 2017

☔ The latest upstream changes (presumably #44654) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 5229443 into rust-lang:master Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"these two types are declared with different lifetimes..." not triggering within structs
8 participants