rustc: Add LLVM nounwind with -C panic=abort
#45031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
It appears that rust/src/librustc_trans/callee.rs Lines 108 to 110 in a0db04b I'm not sure why we have 2 places of code here, but I imagine that needs to be fixed. |
|
Excellent point! I've updated and extended the test case for that as well. |
alexcrichton
commented
Oct 5, 2017
src/test/run-pass/no-landing-pads.rs
Outdated
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| // compile-flags: -Z no-landing-pads |
There was a problem hiding this comment.
AFAIK this test has basically always been invalid, and -C panic=abort is tested through many other tests
|
Why did you remove the r=me if you condition the |
|
Would you prefer I just remove the It's true that yes, |
|
I know |
|
@bors: r=arielb1 |
|
📌 Commit d2348dd has been approved by |
shepmaster
added
the
S-waiting-on-bors
|
⌛ Testing commit d2348dd3d12ced0f53388e9b8899f7df58e1fea7 with merge c5cc2b0add25d809c7384c78e1915ef7156dae00... |
|
💔 Test failed - status-appveyor |
|
Two codegen tests failed on |
carols10cents
added
S-waiting-on-author
This informs LLVM that functions can't unwind, which while it should typically have already been inferred when necessary or otherwise not impact codegen is apparently needed on targets like ARM to avoid references to unnecessary symbols. Closes rust-lang#44992
alexcrichton
force-pushed
the
nounwind
branch
from
d2348dd
to
24cc38e
Compare
|
@bors: r=arielb1 |
|
📌 Commit 24cc38e has been approved by |
bors
added a commit
that referenced
this pull request
Oct 13, 2017
rustc: Add LLVM `nounwind` with `-C panic=abort` This informs LLVM that functions can't unwind, which while it should typically have already been inferred when necessary or otherwise not impact codegen is apparently needed on targets like ARM to avoid references to unnecessary symbols. Closes #44992
kennytm
added
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
japaric
added a commit
to rust-embedded/cortex-m-rt
that referenced
this pull request
Oct 19, 2017
TL;DR thanks to rust-lang/rust#45031 we no longer need this Now with -C panic=abort all functions are marked with the `nouwind` attribute in LLVM-IR. With this change LLVM won't generate undefined references to `__aeabi_unwind_cpp_pr0` et al. which we don't use / supply but are required by the AEABI standard in the case that a function that throw exceptions exists (semantically, we never have any of those function with panic=abort but the LLVM-IR didn't reflect this before).
adamgreig
pushed a commit
to rust-embedded/cortex-m
that referenced
this pull request
Jan 12, 2022
TL;DR thanks to rust-lang/rust#45031 we no longer need this Now with -C panic=abort all functions are marked with the `nouwind` attribute in LLVM-IR. With this change LLVM won't generate undefined references to `__aeabi_unwind_cpp_pr0` et al. which we don't use / supply but are required by the AEABI standard in the case that a function that throw exceptions exists (semantically, we never have any of those function with panic=abort but the LLVM-IR didn't reflect this before).
reitermarkus
pushed a commit
to reitermarkus/cortex-m
that referenced
this pull request
May 4, 2022
TL;DR thanks to rust-lang/rust#45031 we no longer need this Now with -C panic=abort all functions are marked with the `nouwind` attribute in LLVM-IR. With this change LLVM won't generate undefined references to `__aeabi_unwind_cpp_pr0` et al. which we don't use / supply but are required by the AEABI standard in the case that a function that throw exceptions exists (semantically, we never have any of those function with panic=abort but the LLVM-IR didn't reflect this before).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This informs LLVM that functions can't unwind, which while it should typically
have already been inferred when necessary or otherwise not impact codegen is
apparently needed on targets like ARM to avoid references to unnecessary
symbols.
Closes #44992