Remove support for the PNaCl target (le32-unknown-nacl) #45041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @eddyb |
|
@bors: r+ |
|
📌 Commit 327116a has been approved by |
shepmaster
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 9, 2017
Remove support for the PNaCl target (le32-unknown-nacl) This removes support for the `le32-unknown-nacl` target which is currently supported by rustc on tier 3. Despite the "nacl" in the name, the target doesn't output native code (x86, ARM, MIPS), instead it outputs binaries in the PNaCl format. There are two reasons for the removal: * Google [has announced](https://blog.chromium.org/2017/05/goodbye-pnacl-hello-webassembly.html) deprecation of the PNaCl format. The suggestion is to migrate to wasm. Happens we already have a wasm backend! * Our PNaCl LLVM backend is provided by the fastcomp patch set that the LLVM fork used by rustc contains in addition to vanilla LLVM (`src/llvm/lib/Target/JSBackend/NaCl`). Upstream LLVM doesn't have PNaCl support. Removing PNaCl support will enable us to move away from fastcomp (#44006) and have a lighter set of patches on top of upstream LLVM inside our LLVM fork. This will help distribution packagers of Rust. Fixes #42420
|
☀️ Test successful - status-appveyor, status-travis |
rtzoeller
added a commit
to rtzoeller/nix
that referenced
this pull request
Jun 6, 2022
Remove obsolete references to target_env = wasi, target_os = nacl, target_os = osx, and a typo'd target_os = fushsia that didn't compile when fixed. - target_env = wasi is dead: rust-lang/rust#60117 - target_os = nacl is dead: rust-lang/rust#45041 - target_os = osx is dead, but I can't find a link.
bors bot
added a commit
to nix-rust/nix
that referenced
this pull request
Jun 9, 2022
1735: Cleanup cfg blocks r=asomers a=rtzoeller Remove obsolete references to target_env = wasi, target_os = nacl, target_os = osx, and a typo'd target_os = fushsia that didn't compile when fixed. - target_env = wasi is dead: rust-lang/rust#60117 - target_os = nacl is dead: rust-lang/rust#45041 - target_os = osx is dead, but I can't find a link. Found while exploring `--check-cfg`, as mentioned in #1734. Co-authored-by: Ryan Zoeller <[email protected]>
Urgau
added a commit
to Urgau/rust
that referenced
this pull request
Jan 19, 2023
See rust-lang#45041 for the removal of the target (le32-unknown-nacl).
Urgau
added a commit
to Urgau/rust
that referenced
this pull request
Jan 19, 2023
- `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: `nvptx64-nvidia-cuda` - `target_arch=le32`: target was removed (rust-lang#45041) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 22, 2023
…k-cfgs, r=Mark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang#45041) - ~~`release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449 (despite the changes being done more than 6 months ago there hasn't been any rustfmt subtree sync) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).
Urgau
added a commit
to Urgau/rust
that referenced
this pull request
Jan 25, 2023
See rust-lang#45041 for the removal of the target (le32-unknown-nacl).
Urgau
added a commit
to Urgau/rust
that referenced
this pull request
Jan 25, 2023
- `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: `nvptx64-nvidia-cuda` - `target_arch=le32`: target was removed (rust-lang#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 29, 2023
…k-cfgs, r=Mark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 30, 2023
…cfgs, r=Mark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Jan 31, 2023
…ark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang/rust#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).
thomcc
pushed a commit
to tcdi/postgrestd
that referenced
this pull request
May 31, 2023
See rust-lang/rust#45041 for the removal of the target (le32-unknown-nacl).
thomcc
pushed a commit
to tcdi/postgrestd
that referenced
this pull request
May 31, 2023
…ark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang/rust#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for the
le32-unknown-nacltarget which is currently supported by rustc on tier 3. Despite the "nacl" in the name, the target doesn't output native code (x86, ARM, MIPS), instead it outputs binaries in the PNaCl format.There are two reasons for the removal:
src/llvm/lib/Target/JSBackend/NaCl). Upstream LLVM doesn't have PNaCl support. Removing PNaCl support will enable us to move away from fastcomp (Tracking issue for supporting asm.js and WebAssembly without Fastcomp #44006) and have a lighter set of patches on top of upstream LLVM inside our LLVM fork. This will help distribution packagers of Rust.Fixes #42420