Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trait summaries for std::fmt #45042

Merged
merged 1 commit into from
Oct 8, 2017
Merged

Update trait summaries for std::fmt #45042

merged 1 commit into from
Oct 8, 2017

Conversation

brennie
Copy link

@brennie brennie commented Oct 5, 2017

This patch is part of #29355.

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brennie
Copy link
Author

brennie commented Oct 5, 2017

I'm not sure if the sub-task I was intending to tackle (all of the traits should say "C formatting", where C is the char, rather than their current boilerplate. Except Write. And Display.) was only about the summaries. If further revision of the trait docs are required I can attempt to give it a go.

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2017
@steveklabnik
Copy link
Member

This looks great, thanks so much!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Oct 7, 2017

📌 Commit 276bebe has been approved by steveklabnik

kennytm added a commit to kennytm/rust that referenced this pull request Oct 8, 2017
…, r=steveklabnik

Update trait summaries for std::fmt

This patch is part of rust-lang#29355.

r? @steveklabnik
bors added a commit that referenced this pull request Oct 8, 2017
Rollup of 10 pull requests

- Successful merges: #45018, #45042, #45052, #45053, #45058, #45060, #45081, #45083, #45090, #45094
- Failed merges:
@bors bors merged commit 276bebe into rust-lang:master Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants