rustc: Handle #[no_mangle] anywhere in a crate
#45189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
Looks good to me. Some tests are failing though. |
alexcrichton
force-pushed
the
thinlto-allocators
branch
from
1b8e3de
to
c7aa741
Compare
|
Ok I changed this to just handling @bors: r=michaelwoerister |
|
📌 Commit c7aa741 has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 12, 2017
…michaelwoerister rustc: Handle `#[no_mangle]` anywhere in a crate This commit updates the reachability pass of the compiler to seed the local worklist with `#[no_mangle]`-like items anywhere in a crate, not just those reachable from public items. Closes rust-lang#45165
|
@bors r- asm.js's The test involves |
|
@alexcrichton So what exactly is going on here? I.e. what is the root cause of the problem this PR tries to fix? |
aidanhs
added
the
S-waiting-on-author
|
@michaelwoerister the problem is that ThinLTO is internalizing these symbols when they otherwise need to be exposed. That in turns happens because locally defined allocator symbols aren't in the list of "rust exported symbols" (the |
|
@alexcrichton But why is that a problem with ThinLTO but not the regular multi-CGU case? |
|
I think that happens is that in normal trans we will translate everything to LLVM and at that time we'll recognize Does that make sense? |
This commit updates the reachability pass of the compiler to seed the local worklist with `#[linkage]`-like items anywhere in a crate, not just those reachable from public items. Closes rust-lang#45165
alexcrichton
force-pushed
the
thinlto-allocators
branch
from
c7aa741
to
6cae080
Compare
|
Also I'm removing that test once and for all, it has caused dozens and dozens of failures and has literally never caught a regression. @bors: r=michaelwoerister |
|
📌 Commit 6cae080 has been approved by |
|
|
Thanks for the clarification. |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 13, 2017
…michaelwoerister rustc: Handle `#[no_mangle]` anywhere in a crate This commit updates the reachability pass of the compiler to seed the local worklist with `#[no_mangle]`-like items anywhere in a crate, not just those reachable from public items. Closes rust-lang#45165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the reachability pass of the compiler to seed the local
worklist with
#[no_mangle]-like items anywhere in a crate, not just thosereachable from public items.
Closes #45165