ci: Upgrade Android SDK/NDK and refactor to use sdkmanager/avdmanager. #45580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-author
|
Looks great to me, thanks! r=me with a passing set of CI |
|
@kennytm I'm working on libc android ci, see rust-lang/libc#825. It's is necessary to pass |
kennytm
force-pushed
the
sdkmanager
branch
13 times, most recently
from
3f3b2f8
to
29bdc33
Compare
|
So this is the final list of changes and rationale:
(The last |
|
All looks and sounds great to me, thanks so much for investigating all this @kennytm! |
* SDK tools is upgraded to 27.0.0.
- Refactored to use `sdkmanager`/`avdmanager` instead of the deprecated
`android` tool.
* The Java version used by Android SDK is downgraded to OpenJDK-8, in order
to download the SDK through HTTPS.
* NDK is upgrade to r15c.
- Dropped support for android-9 (2.3 / Gingerbread), the minimal
supported version is now android-14 (4.0 / Ice Cream Sandwich).
- Changed the default Android compiler from GCC to clang.
- For details of change introduced by NDK r15, see
https://github.com/android-ndk/ndk/wiki/Changelog-r15.
kennytm
changed the title
|
@bors r=alexcrichton |
|
📌 Commit c46b04c has been approved by |
kennytm
added
relnotes
bors
added a commit
that referenced
this pull request
Oct 28, 2017
ci: Upgrade Android SDK/NDK and refactor to use sdkmanager/avdmanager.
* SDK tools is upgraded to 27.0.0.
* Stopped using the deprecated `android` tool, instead use the recommended `sdkmanager` and `avdmanager`.
* NDK is upgrade to r15c.
The r15 series [dropped support for android-9](https://github.com/android-ndk/ndk/wiki/Changelog-r15) (2.3 / Gingerbread), the minimal supported version is now android-14 (4.0 / Ice Cream Sandwich).
r? @alexcrichton
(WIP, haven't confirmed if the change really works yet)
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Oct 31, 2017
[beta] ci: Upgrade Android SDK/NDK and refactor to use sdkmanager/avdmanager. This is a backport of #45580 r? @alexcrichton
malbarbo
added a commit
to malbarbo/cross
that referenced
this pull request
Dec 10, 2017
After the ndk update used to build libstd rust-lang/rust#45580, i686-linux-android binaries stopped working cross-rs#143. It's seem that the new toolchain is emitting instructions that the default qemu-i386 cpu does not support. Using -cpu n270 (common in android i686 phones), fix the problem. Fixes cross-rs#143.
japaric
pushed a commit
to cross-rs/cross
that referenced
this pull request
Dec 11, 2017
Use -cpu n270 to run i686-linux-android binaries After the ndk update used to build libstd rust-lang/rust#45580, i686-linux-android binaries stopped working #143. It's seem that the new toolchain is emitting instructions that the default qemu-i386 cpu does not support. Using -cpu n270 (common in android i686 phones), fix the problem. Fixes #143.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK tools is upgraded to 27.0.0.
Stopped using the deprecated
androidtool, instead use the recommendedsdkmanagerandavdmanager.NDK is upgrade to r15c.
The r15 series dropped support for android-9 (2.3 / Gingerbread), the minimal supported version is now android-14 (4.0 / Ice Cream Sandwich).
r? @alexcrichton
(WIP, haven't confirmed if the change really works yet)