Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize some span operations #45602

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Optimize some span operations #45602

merged 1 commit into from
Nov 1, 2017

Conversation

petrochenkov
Copy link
Contributor

Do not decode span data twice/thrice/etc unnecessarily.
Applied to stable hashing and all methods in impl Span.

Follow up to #44646
r? @michaelwoerister

@petrochenkov
Optimize some span operations
06f7f1f 
Decode span data only once
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2017
@michaelwoerister
Copy link
Member

Awesome, thank you @petrochenkov!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 30, 2017

📌 Commit 06f7f1f has been approved by michaelwoerister

@bors
Copy link
Contributor

bors commented Oct 30, 2017

⌛ Testing commit 06f7f1f with merge c3afd63682deed6971a457963b7444a59288e67d...

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2017
@bors
Copy link
Contributor

bors commented Oct 30, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Oct 30, 2017 •
edited
Loading

@bors retry

dist-aarch64-linux and dist-armhf-linux errored without starting. Possibly related to https://www.traviscistatus.com/incidents/4vdl52d28hz3.

@bors
Copy link
Contributor

bors commented Oct 31, 2017

⌛ Testing commit 06f7f1f with merge 330bd39ef4de9cad7117f155e43dc55e20c7a199...

@bors
Copy link
Contributor

bors commented Oct 31, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Oct 31, 2017

@bors retry

Travis incident, no jobs starting. https://www.traviscistatus.com/incidents/xgpn2tq6mx7k

kennytm added a commit to kennytm/rust that referenced this pull request Nov 1, 2017
@kennytm
Rollup merge of rust-lang#45602 - petrochenkov:ospan, r=michaelwoerister
e01dcf4 
Optimize some span operations

Do not decode span data twice/thrice/etc unnecessarily.
Applied to stable hashing and all methods in `impl Span`.

Follow up to rust-lang#44646
r? @michaelwoerister
@kennytm kennytm mentioned this pull request Nov 1, 2017
Merged
bors added a commit that referenced this pull request Nov 1, 2017
@bors
Auto merge of #45674 - kennytm:rollup, r=kennytm
7402866 
Rollup of 14 pull requests

- Successful merges: #45450, #45579, #45602, #45619, #45624, #45644, #45646, #45648, #45649, #45650, #45652, #45660, #45664, #45671
- Failed merges:
@bors bors merged commit 06f7f1f into rust-lang:master Nov 1, 2017
@petrochenkov petrochenkov deleted the ospan branch June 5, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petrochenkov @michaelwoerister @bors @kennytm