Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix broken link in build-powerpc64le-toolchain.sh #45734

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Nov 3, 2017

r? @rust-lang/infra

This is just an emergency fix to keep bors running for another week. I think the numbers will be broken soon. Can we verify if this statement is still true later?

First, download the CentOS7 glibc.ppc64le and relevant header files.
(upstream ppc64le support wasn't added until 2.19, which el7 backported.)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2017
@kennytm
Copy link
Member Author

kennytm commented Nov 3, 2017

Or we could cache those files in our S3 again...

@alexcrichton
Copy link
Member

@bors: r+ p=100

@bors
Copy link
Contributor

bors commented Nov 3, 2017

📌 Commit 1f95c6d has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Nov 3, 2017

⌛ Testing commit 1f95c6d with merge 525b81d...

bors added a commit that referenced this pull request Nov 3, 2017
ci: Fix broken link in `build-powerpc64le-toolchain.sh`

r? @rust-lang/infra

This is just an emergency fix to keep bors running for another week. I think the numbers will be broken soon. Can we verify if this statement is still true later?

> First, download the CentOS7 glibc.ppc64le and relevant header files.
> (upstream ppc64le support wasn't added until 2.19, which el7 backported.)
@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Nov 3, 2017
@kennytm
Copy link
Member Author

kennytm commented Nov 3, 2017

cc @cuviper

@kennytm
Copy link
Member Author

kennytm commented Nov 3, 2017

Looks like we could use the URL http://vault.centos.org/altarch/7.3.1611/os/ppc64le/Packages/ as well, if we absolutely want to stay on the same Centos version.

@bors
Copy link
Contributor

bors commented Nov 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 525b81d to master...

@bors bors merged commit 1f95c6d into rust-lang:master Nov 3, 2017
@cuviper
Copy link
Member

cuviper commented Nov 3, 2017

@kennytm As long as the basic glibc and kernel versions are the same, our compatibility won't be affected. Bumping to newer package releases shouldn't change ABI at all.

In any case, using a vault link does seem like a better idea for longevity.

Can we verify if this statement is still true later?

I'm not sure what you're asking to verify -- it's just a fact that el7 backported ppc64le support.

@kennytm
Copy link
Member Author

kennytm commented Nov 3, 2017

@cuviper I see. I asked because the ppc64 script looks much simpler and doesn't download anything ^^

@alexcrichton So for the backport to beta we'll switch to http://vault.centos.org/altarch/7.3.1611/os/ppc64le/Packages/ instead of reusing this PR. I'll submit another PR for master using the vault link as well?

@cuviper
Copy link
Member

cuviper commented Nov 3, 2017

Yeah, ppc64(be) has been around much longer and doesn't need special backports, so for that we just use plain upstream versions via crosstool-ng.

@kennytm kennytm deleted the ci-fix-centos-broken-link branch November 3, 2017 17:27
bors added a commit that referenced this pull request Nov 5, 2017
[beta] ci: Fix broken link in `build-powerpc64le-toolchain.sh`

This is almost a backport of #45734, but uses vault.centos.org instead for better longevity.

r? @alexcrichton cc @cuviper
kennytm added a commit to kennytm/rust that referenced this pull request Nov 5, 2017
This commit reverts rust-lang#45734 and applies rust-lang#45744. We expect the vault links
to be more stable than mirror.centos.org.
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants