Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiletest libc dependency can be unix-only #46275

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Compiletest libc dependency can be unix-only #46275

merged 1 commit into from
Nov 28, 2017

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Nov 26, 2017

In main.rs libc is imported as:

#[cfg(unix)]
extern crate libc;

This came up in Manishearth/compiletest-rs#90.

@dtolnay
Compiletest libc dependency can be unix-only
5d8d04a 
In main.rs libc is imported as:

    #[cfg(unix)]
    extern crate libc;
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@dtolnay dtolnay mentioned this pull request Nov 26, 2017
Merged
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2017
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

r? @Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Nov 26, 2017

📌 Commit 5d8d04a has been approved by Mark-Simulacrum

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 27, 2017
@kennytm
Rollup merge of rust-lang#46275 - dtolnay:compiletest-libc, r=Mark-Si…
81ba352 
…mulacrum

Compiletest libc dependency can be unix-only

In main.rs libc is imported as:

```rust
#[cfg(unix)]
extern crate libc;
```

This came up in Manishearth/compiletest-rs#90.
@kennytm kennytm mentioned this pull request Nov 27, 2017
Merged
bors added a commit that referenced this pull request Nov 27, 2017
@bors
Auto merge of #46312 - kennytm:rollup, r=kennytm
b087a99 
Rollup of 10 pull requests

- Successful merges: #45506, #46174, #46231, #46240, #46249, #46258, #46262, #46275, #46282, #46285
- Failed merges:
@bors bors merged commit 5d8d04a into rust-lang:master Nov 28, 2017
@dtolnay dtolnay deleted the compiletest-libc branch May 26, 2018 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dtolnay @rust-highfive @Mark-Simulacrum @bors @kennytm @nikomatsakis