Ignore CTFE errors while lowering patterns #47382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
approved these changes
Jan 12, 2018
eddyb
reviewed
Jan 12, 2018
src/librustc_const_eval/pattern.rs
Outdated
| @@ -280,7 +280,7 @@ impl<'a, 'tcx> Pattern<'tcx> { | |||
| let mut pcx = PatternContext::new(tcx, param_env_and_substs, tables); | |||
| let result = pcx.lower_pattern(pat); | |||
| if !pcx.errors.is_empty() { | |||
| span_bug!(pat.span, "encountered errors lowering pattern: {:?}", pcx.errors) | |||
| debug!("encountered errors lowering pattern: {:?}", pcx.errors) | |||
There was a problem hiding this comment.
Wait, can't this be tcx.sess.delay_span_bug? That would make sure we have some other error emitted.
There was a problem hiding this comment.
Yeah that worked. I am going to add a commit to replace debug!() with delay_span_bug().
|
@bors r+ Thanks! |
|
📌 Commit 42410a9 has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 12, 2018
Ignore CTFE errors while lowering patterns Closes rust-lang#43105. r? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43105.
r? @eddyb