Add ./x.py check src/{libstd,libtest,librustc} #47460
Conversation
|
cc @rust-lang/compiler |
Mark-Simulacrum
changed the title
Mark-Simulacrum
force-pushed
the
bootstrap-check
branch
from
206c1c4
to
cc8717f
Compare
| If no arguments are passed then the complete artifacts are compiled: std, test, and rustc. Note | ||
| also that since we use `cargo check`, by default this will automatically enable incremental | ||
| compilation, so there's no need to pass it separately, though it won't hurt. We also completely | ||
| ignore the stage passed, as there's no way to compile in non-stage 0 without actually building |
There was a problem hiding this comment.
Checking in non-stage-0 may still be useful if we want to check libstd after some new semantic is implemented:
./x.py build --stage 0 src/librustc
./x.py check --keep-stage 1 --stage 1 src/libstd
# edit
./x.py check --keep-stage 1 --stage 1 src/libstd
# edit
./x.py check --keep-stage 1 --stage 1 src/libstd
|
What exactly do these do? |
|
This runs |
|
OK, that's great! |
kennytm
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #47528) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Oops sorry about that, looks great to me! r=me |
Mark-Simulacrum
force-pushed
the
bootstrap-check
branch
from
cc8717f
to
7319232
Compare
|
@bors r=alexcrichton |
|
📌 Commit 7319232 has been approved by |
|
Should this option be mentioned in https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#the-build-system? |
|
Probably, yes. I'll open an issue. |
|
☔ The latest upstream changes (presumably #47678) made this pull request unmergeable. Please resolve the merge conflicts. |
This currently only supports a limited subset of the full compilation, but is likely 90% of what people will want and is possible without building a full compiler (i.e., running LLVM). In theory, this means that contributors who don't want to build LLVM now have an easy way to compile locally, though running tests won't work.
Mark-Simulacrum
force-pushed
the
bootstrap-check
branch
from
7319232
to
6aeb1cf
Compare
|
@bors r=alexcrichton |
|
📌 Commit 6aeb1cf has been approved by |
kennytm
added
S-waiting-on-bors
…alexcrichton
Add ./x.py check src/{libstd,libtest,librustc}
This currently only supports a limited subset of the full compilation,
but is likely 90% of what people will want and is possible without
building a full compiler (and also building LLVM). In theory, this means
that contributors who don't want to build LLVM now have an easy way to
compile locally, though running tests won't work.
This currently only supports a limited subset of the full compilation,
but is likely 90% of what people will want and is possible without
building a full compiler (and also building LLVM). In theory, this means
that contributors who don't want to build LLVM now have an easy way to
compile locally, though running tests won't work.