Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Attempt to fix prerelease version calculation #47546

Closed
wants to merge 1 commit into from
Closed

[beta] Attempt to fix prerelease version calculation #47546

wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

We got #47396 merged but it looks like rcs failed to deploy the beta because
when it tried to calculate the beta version its cwd was different. Let's try to
fix this bug and fix auto-deploy by explicitly setting the current_dir for git
commands.

@alexcrichton
[beta] Attempt to fix prerelease version calculation
b67cb01 
We got rust-lang#47396 merged but it looks like rcs failed to deploy the beta because
when it tried to calculate the beta version its cwd was different. Let's try to
fix this bug and fix auto-deploy by explicitly setting the `current_dir` for git
commands.
@alexcrichton
Copy link
Member Author

r? @kennytm

@alexcrichton
Copy link
Member Author

Looks like the beta was calculated as 1.24.0-beta.5 (597549eff 2018-01-18) though so it appears to be working otherwise!

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2018
@kennytm
Copy link
Member

kennytm commented Jan 18, 2018

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jan 18, 2018

📌 Commit b67cb01 has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2018
@alexcrichton alexcrichton mentioned this pull request Jan 18, 2018
Merged
@alexcrichton
Copy link
Member Author

I'm gonna close in favor of #47553 as the queue's a little slow now...

bors added a commit that referenced this pull request Jan 18, 2018
@bors
Auto merge of #47553 - alexcrichton:beta-next, r=alexcrichton
1262787 
[beta] Rollup + backports

This is a rollup of two PRs:

* #47546
* #47431

and a backport of two PRs:

* #47505
* #47220
@alexcrichton alexcrichton deleted the fix-beta branch March 19, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcrichton @kennytm @bors