Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doctests for BTreeSet to use BTreeSet (not BTreeMap) #47625

Merged
merged 1 commit into from
Jan 22, 2018
Merged

fix doctests for BTreeSet to use BTreeSet (not BTreeMap) #47625

merged 1 commit into from
Jan 22, 2018

Conversation

astraw
Copy link
Contributor

@astraw astraw commented Jan 20, 2018

This fixes #47624

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @bluss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm
Copy link
Member

kennytm commented Jan 21, 2018

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 21, 2018

📌 Commit 4d08d05 has been approved by kennytm

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 21, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 21, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47625 - astraw:btreeset-doctest-fix, r=kennytm
50e3836 
fix doctests for BTreeSet to use BTreeSet (not BTreeMap)

This fixes rust-lang#47624
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 21, 2018
Merged
bors added a commit that referenced this pull request Jan 21, 2018
@bors
Auto merge of #47644 - GuillaumeGomez:rollup, r=GuillaumeGomez
ff2a7c8 
Rollup of 9 pull requests

- Successful merges: #47247, #47334, #47512, #47582, #47595, #47625, #47632, #47633, #47637
- Failed merges:
@bors bors merged commit 4d08d05 into rust-lang:master Jan 22, 2018
@astraw astraw deleted the btreeset-doctest-fix branch January 22, 2018 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bluss bluss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doctest for BTreeSet::split_off documents BTreeMap::split_off
5 participants
@astraw @rust-highfive @kennytm @bors @bluss