Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct E0619 span re method call receivers whose type must be known #48028

Merged
merged 1 commit into from
Feb 7, 2018
Merged

correct E0619 span re method call receivers whose type must be known #48028

merged 1 commit into from
Feb 7, 2018

Conversation

zackmdavis
Copy link
Member

Previously, when the type of a method receiver could not be determined,
the error message would, potentially confusingly, highlight the span of
the entire method call.

unknown_receiver_type

Resolves #36598, resolves #42234.

@zackmdavis
correct E0619 span re method call receivers whose type must be known
b55e07e 
Previously, when the type of a method receiver could not be determined,
the error message would, potentially confusingly, highlight the span of
the entire method call.

Resolves rust-lang#36598, resolves rust-lang#42234.
@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2018
@estebank
Copy link
Contributor

estebank commented Feb 6, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 6, 2018

📌 Commit b55e07e has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2018
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 7, 2018
@Manishearth
Rollup merge of rust-lang#48028 - zackmdavis:and_the_span_of_the_unkn…
732c830 
…own_type, r=estebank

correct E0619 span re method call receivers whose type must be known

Previously, when the type of a method receiver could not be determined,
the error message would, potentially confusingly, highlight the span of
the entire method call.

![unknown_receiver_type](https://user-images.githubusercontent.com/1076988/35838930-a595b17c-0aa2-11e8-9364-6b8e2329f051.png)

Resolves rust-lang#36598, resolves rust-lang#42234.
@Manishearth Manishearth mentioned this pull request Feb 7, 2018
Merged
bors added a commit that referenced this pull request Feb 7, 2018
@bors
Auto merge of #48053 - Manishearth:rollup, r=Manishearth
29c8276 
Rollup of 10 pull requests

- Successful merges: #47613, #47631, #47810, #47883, #47922, #47944, #48014, #48018, #48020, #48028
- Failed merges:
@bors bors merged commit b55e07e into rust-lang:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
6 participants
@zackmdavis @rust-highfive @estebank @bors @pnkfelix @pietroalbini