-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing pieces for sparc-linux-gnu support #48297
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ |
📌 Commit 5123547 has been approved by |
5123547
to
8b5dab0
Compare
I have just updated that PR. I fixed two small issues (wrong name of the OpenSSL configuration and CPU name) and also added "sparc-unknown-linux-gnu" to tools/build-manifest/src/main.rs. |
@estebank Can you tell bors to pick the updated commits? |
@bors r+ |
📌 Commit 8b5dab0 has been approved by |
8b5dab0
to
a3b1a0b
Compare
@sanxiyn Sorry, I just noticed that I forgot to add |
Sure. @bors r+ |
📌 Commit a3b1a0b has been approved by |
b326273
to
283626f
Compare
283626f
to
84aae4e
Compare
@sanxiyn Ok, one more :). We decided to pass "-mv8plus" to the linker which is useful when cross-building. The rest is fine now, we rechecked all bits and pieces. |
@bors r+ |
📌 Commit 84aae4e has been approved by |
Add missing pieces for sparc-linux-gnu support I noticed that while Rust has CABI support for 32-bit SPARC, there are still some pieces missing to be able to use Rust on a 32-Bit SPARC system like Gentoo which still defaults to a 32-bit port unlike Debian's sparc64 port. This PR is an attempt to add the missing pieces. I will send the necessary changes for libc in a separate PR. CC @jrtc27
I noticed that while Rust has CABI support for 32-bit SPARC, there are still some pieces missing to be able to use Rust on a 32-Bit SPARC system like Gentoo which still defaults to a 32-bit port unlike Debian's sparc64 port.
This PR is an attempt to add the missing pieces. I will send the necessary changes for libc in a separate PR.
CC @jrtc27