Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] 1.24.1 stable release #48445

Merged
merged 6 commits into from
Feb 27, 2018
Merged

[stable] 1.24.1 stable release #48445

merged 6 commits into from
Feb 27, 2018

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Feb 22, 2018 •
edited
Loading

The includes the following commits:

alexcrichton and others added 2 commits February 22, 2018 14:34
@alexcrichton @Mark-Simulacrum
rustc: Don't use relative paths for extended errors
a5cf56d 
These no longer work now that Cargo changes the cwd of rustc while it's running.
Instead use an absolute path that's set by rustbuild.
@nikomatsakis @Mark-Simulacrum
temporarily disable rust-lang#46833 due to rust-lang#48251
6a600f8
@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2018
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 22, 2018
Closed
@alexcrichton
Copy link
Member

Since stable is so much more "expensive" to release for us I'd personally be far more comfortable only landing changes that are already released and tested in beta and stable, but would that delay this too much?

@Mark-Simulacrum
Copy link
Member Author

Hm, I don't think so -- I'll go ahead and merge the relevant PRs that exist and try to put up PRs where they don't. We're currently targeting Monday for the release, though I have a feeling that will slip to Thursday while we wait for confirmation from stakeholders (after we've uploaded artifacts to dev-static).

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 23, 2018
Closed
@Eh2406 Eh2406 mentioned this pull request Feb 23, 2018
Closed
@Eh2406
Copy link
Contributor

Eh2406 commented Feb 23, 2018

There is some discussion of asking for a 1.24.1 to give better error messages for the Cargo GitHub Win7 thing. I have no opinion just trying to connect the discussions.

@Mark-Simulacrum Mark-Simulacrum requested review from alexcrichton and removed request for alexcrichton February 23, 2018 20:30
@alexcrichton
Copy link
Member

I've added a commit which includes rust-lang/cargo#5086 as well.

@matklad matklad mentioned this pull request Feb 27, 2018
Closed
@Mark-Simulacrum
Copy link
Member Author

Discussed with @alexcrichton, we're going to go ahead and merge this. We'll be discussing this further during the next core team meeting and deciding whether or not we will actually release 1.24.1 then.

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Feb 27, 2018

📌 Commit 9853d20 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2018
@kennytm
Copy link
Member

kennytm commented Feb 27, 2018

@bors p=1000

@bors
Copy link
Contributor

bors commented Feb 27, 2018

⌛ Testing commit 9853d20 with merge f81cfc31499534859f933aa1a68f58ad801a4d14...

@bors
Copy link
Contributor

bors commented Feb 27, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2018
@Mark-Simulacrum
Copy link
Member Author

@bors retry -- appveyor timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2018
@bors
Copy link
Contributor

bors commented Feb 27, 2018

⌛ Testing commit 9853d20 with merge d3ae9a9...

bors added a commit that referenced this pull request Feb 27, 2018
@bors
Auto merge of #48445 - Mark-Simulacrum:stable-next, r=alexcrichton
d3ae9a9 
[stable] 1.24.1 stable release

The includes the following commits:
 - 6a600f8: Fixes #48251, unwinding through FFI no longer aborts
 - cuviper@b445a52: Fixes #48308, fixing the error index generator
 - f8e00d0: Fixes #48318 by emitting UTF-16 output on MSVC targets.
 - 2a0af8c448: Bumps the version number to 1.24.1.
 - 93220f0f45: Release notes
 - 6031718d8836f95bbfeddfaa63f1ee1d66e53f26: Cargo TLS warnings on Windows.
@bors
Copy link
Contributor

bors commented Feb 27, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2018
@alexcrichton
Copy link
Member

All dist targets succeeded, merging manually

@alexcrichton alexcrichton merged commit 9853d20 into rust-lang:stable Feb 27, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the stable-next branch February 28, 2018 19:17
@alexcrichton alexcrichton mentioned this pull request Jul 24, 2018
Closed
yuriks added a commit to yuriks/reference that referenced this pull request Sep 25, 2020
@yuriks
Update guarantees of unwinding past an extern "C" function
7657115 
The current docs say it will abort, however that behavior was actually reverted in rust-lang/rust#48445 and is not what currently happens in stable.
@yuriks yuriks mentioned this pull request Sep 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Mark-Simulacrum @rust-highfive @alexcrichton @Eh2406 @bors @kennytm @aturon @nikomatsakis