Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add force-frame-pointer flag to allow control of frame pointer ommision #48786

Merged
merged 4 commits into from
May 1, 2018
Merged

Add force-frame-pointer flag to allow control of frame pointer ommision #48786

merged 4 commits into from
May 1, 2018

Commits on May 1, 2018

  1. Don't force-enable frame pointers when generating debug info 

    We apparently used to generate bad/incomplete debug info causing
debuggers not to find symbols of stack allocated variables. This was
somehow worked around by having frame pointers.

With the current codegen, this seems no longer necessary, so we can
remove the code that force-enables frame pointers whenever debug info
is requested.

Since certain situations, like profiling code profit from having frame
pointers, we add a -Cforce-frame-pointers flag to always enable frame
pointers.

Fixes rust-lang#11906
    @dotdash @nagisa
    dotdash authored and nagisa committed May 1, 2018
    Configuration menu
    Copy the full SHA
    5b800c2 View commit details
    Browse the repository at this point in the history

  2. Rework force-frame-pointer 

    This reworks the force-frame-pointer PR to explicitly only consider the
value of the flag if it is provided, and use a target default otherwise.

Something that was tried but not kept was renaming the flag to
`frame-pointer`, because for flag `frame-pointer=no`, there is no
guarante, that LLVM will elide *all* the frame pointers; oposite of what
the literal reading of the flag would suggest.
    @nagisa
    nagisa committed May 1, 2018
    Configuration menu
    Copy the full SHA
    09d2db4 View commit details
    Browse the repository at this point in the history

  3. Don’t eliminate frame pointers on apple by default

    @nagisa
    nagisa committed May 1, 2018
    Configuration menu
    Copy the full SHA
    969449f View commit details
    Browse the repository at this point in the history

  4. Force frame pointers for the backtrace test

    @nagisa
    nagisa committed May 1, 2018
    Configuration menu
    Copy the full SHA
    7ec0452 View commit details
    Browse the repository at this point in the history