Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make assert a built-in procedural macro #48813

Merged
merged 3 commits into from
Mar 16, 2018
Merged

Make assert a built-in procedural macro #48813

merged 3 commits into from
Mar 16, 2018

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Mar 7, 2018

Makes assert macro a built-in one without touching its functionality. This is a prerequisite for RFC 2011 (#44838).

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2018
@pietroalbini
Copy link
Member

Ping from triage @aturon! This PR needs your review.

@aturon
Copy link
Member

aturon commented Mar 12, 2018

cc @rust-lang/libs, I'm not a good reviewer for this.

@alexcrichton
Copy link
Member

@bors: r+

Thanks @sinkuu!

@bors
Copy link
Contributor

bors commented Mar 12, 2018

📌 Commit cb5be1b has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2018
@bors
Copy link
Contributor

bors commented Mar 14, 2018

⌛ Testing commit cb5be1b with merge 327ced3d8cb74350ebc18dabf48263882e4a4fe1...

@bors
Copy link
Contributor

bors commented Mar 14, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 14, 2018
@sinkuu
Copy link
Contributor Author

sinkuu commented Mar 14, 2018

Legit failure.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2018
@sinkuu
Escape stringified expression
4a254c0 
Payload of `Literal` token must be escaped.
Also print printable non-ASCII characters.
@sinkuu
Copy link
Contributor Author

sinkuu commented Mar 14, 2018

./x.py test src/tools/cargo --stage 2 (where bors failed) passed locally, so it should be ok.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 14, 2018

📌 Commit 4a254c0 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2018
@bors
Copy link
Contributor

bors commented Mar 16, 2018

⌛ Testing commit 4a254c0 with merge 5f3996c...

bors added a commit that referenced this pull request Mar 16, 2018
@bors
Auto merge of #48813 - sinkuu:build_in_assert_macro, r=alexcrichton
5f3996c 
Make `assert` a built-in procedural macro

Makes `assert` macro a built-in one without touching its functionality. This is a prerequisite for RFC 2011 (#44838).
@bors
Copy link
Contributor

bors commented Mar 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5f3996c to master...

@bors bors merged commit 4a254c0 into rust-lang:master Mar 16, 2018
@sinkuu sinkuu deleted the build_in_assert_macro branch March 16, 2018 13:29
@durka
Copy link
Contributor

durka commented Apr 5, 2018

Before this PR you could invoke assert as std::assert!(...) given #![feature(use_extern_macros)], but not anymore. Intended?

@sinkuu
Copy link
Contributor Author

sinkuu commented Apr 6, 2018

I overlooked that. Is it possible to export built-in macros via std?

@ollie27 ollie27 mentioned this pull request May 6, 2018
Closed
@petrochenkov petrochenkov mentioned this pull request May 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sinkuu @rust-highfive @pietroalbini @aturon @alexcrichton @bors @durka @kennytm