Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy: Add a check for stray .stderr and .stdout files in UI test directories #48880

Merged
merged 1 commit into from
Mar 13, 2018
Merged

tidy: Add a check for stray .stderr and .stdout files in UI test directories #48880

merged 1 commit into from
Mar 13, 2018

Conversation

petrochenkov
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2018
@petrochenkov
Copy link
Contributor Author

r? @kennytm

@rust-highfive rust-highfive assigned kennytm and unassigned nikomatsakis Mar 9, 2018
kennytm
kennytm approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check for stray *.stdout as well.

r=me after that.

@petrochenkov petrochenkov changed the title tidy: Add a check for stray .stderr files in UI test directories tidy: Add a check for stray .stderr and .stdout files in UI test directories Mar 9, 2018
@petrochenkov
Copy link
Contributor Author

@bors r=kennytm rollup

@bors
Copy link
Contributor

bors commented Mar 9, 2018

📌 Commit c1a73d2 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2018
@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 9, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#48880 - petrochenkov:badstderr, r=kennytm
56b923e 
tidy: Add a check for stray `.stderr` and `.stdout` files in UI test directories
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 9, 2018
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 10, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#48880 - petrochenkov:badstderr, r=kennytm
b5825e3 
tidy: Add a check for stray `.stderr` and `.stdout` files in UI test directories
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 10, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 10, 2018
@kennytm
Rollup merge of rust-lang#48880 - petrochenkov:badstderr, r=kennytm
f0789c6 
tidy: Add a check for stray `.stderr` and `.stdout` files in UI test directories
@kennytm kennytm mentioned this pull request Mar 10, 2018
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 12, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#48880 - petrochenkov:badstderr, r=kennytm
ffaaa4e 
tidy: Add a check for stray `.stderr` and `.stdout` files in UI test directories
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 12, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 12, 2018
@kennytm
Rollup merge of rust-lang#48880 - petrochenkov:badstderr, r=kennytm
3d2db9b 
tidy: Add a check for stray `.stderr` and `.stdout` files in UI test directories
@kennytm kennytm mentioned this pull request Mar 12, 2018
Merged
bors added a commit that referenced this pull request Mar 12, 2018
@bors
Auto merge of #48955 - kennytm:rollup, r=kennytm
c7cbe14 
Rollup of 13 pull requests

- Successful merges: #48201, #48705, #48725, #48824, #48877, #48880, #48887, #48928, #48934, #48480, #48631, #48898, #48954
- Failed merges:
@bors bors merged commit c1a73d2 into rust-lang:master Mar 13, 2018
@petrochenkov petrochenkov deleted the badstderr branch June 5, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petrochenkov @rust-highfive @bors @kennytm @nikomatsakis