Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the conversion between bit representations and i128 representations #49210

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Fix the conversion between bit representations and i128 representations #49210

merged 1 commit into from
Mar 22, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 20, 2018

fixes #49181

the Discr type now encodes the bit representation instead of i128 or u128 casted to u128.

r? @eddyb

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 20, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 22, 2018

travis likes it now. This should be the last (non-perf) regression of miri for which there are open issues.

@nikomatsakis
Copy link
Contributor

@bors p=5

This is a regression that we ought to fix before cutting next beta.

@nikomatsakis nikomatsakis added this to the 1.25 milestone Mar 22, 2018
@eddyb
Copy link
Member

eddyb commented Mar 22, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Mar 22, 2018

📌 Commit b272749 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2018
@bors
Copy link
Contributor

bors commented Mar 22, 2018

⌛ Testing commit b272749 with merge 73906155af2ed482ba7577222d5ab2db2265d9a3...

@alexcrichton
Copy link
Member

@bors: retry

master changed

@bors
Copy link
Contributor

bors commented Mar 22, 2018

⌛ Testing commit b272749 with merge 52f7e88...

bors added a commit that referenced this pull request Mar 22, 2018
@bors
Auto merge of #49210 - oli-obk:pango_crash, r=eddyb
52f7e88 
Fix the conversion between bit representations and i128 representations

fixes #49181

the `Discr` type now encodes the bit representation instead of `i128` or `u128` casted to `u128`.

r? @eddyb
@bors
Copy link
Contributor

bors commented Mar 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 52f7e88 to master...

@bors bors merged commit b272749 into rust-lang:master Mar 22, 2018
@oli-obk oli-obk deleted the pango_crash branch March 24, 2018 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.

crash while compiling pango 0.1.3
6 participants
@oli-obk @nikomatsakis @eddyb @bors @alexcrichton @pietroalbini