Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DefKey lookup for proc-macro crates. #49273

Merged

Conversation

michaelwoerister
Copy link
Member

Add a special case for proc-macro crates for def_key() in the metadata decoder (like we already have for many other methods in there). In the long run, it would be preferable to get rid of the need for special casing proc-macro crates (see #49271).

Fixes #48739 (though I wasn't able to come up with a regression test, unfortunately)

r? @eddyb

@michaelwoerister michaelwoerister added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 22, 2018
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2018
@eddyb
Copy link
Member

eddyb commented Mar 22, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Mar 22, 2018

📌 Commit a1a3bf2 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2018
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 22, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
…cro-defkey, r=eddyb

Fix DefKey lookup for proc-macro crates.

Add a special case for proc-macro crates for `def_key()` in the metadata decoder (like we already have for many other methods in there). In the long run, it would be preferable to get rid of the need for special casing proc-macro crates (see rust-lang#49271).

Fixes rust-lang#48739 (though I wasn't able to come up with a regression test, unfortunately)

r? @eddyb
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
…cro-defkey, r=eddyb

Fix DefKey lookup for proc-macro crates.

Add a special case for proc-macro crates for `def_key()` in the metadata decoder (like we already have for many other methods in there). In the long run, it would be preferable to get rid of the need for special casing proc-macro crates (see rust-lang#49271).

Fixes rust-lang#48739 (though I wasn't able to come up with a regression test, unfortunately)

r? @eddyb
bors added a commit that referenced this pull request Mar 24, 2018
[beta] A few final backports

Backport of

* #48782
* #49273
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
…cro-defkey, r=eddyb

Fix DefKey lookup for proc-macro crates.

Add a special case for proc-macro crates for `def_key()` in the metadata decoder (like we already have for many other methods in there). In the long run, it would be preferable to get rid of the need for special casing proc-macro crates (see rust-lang#49271).

Fixes rust-lang#48739 (though I wasn't able to come up with a regression test, unfortunately)

r? @eddyb
bors added a commit that referenced this pull request Mar 24, 2018
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 24, 2018
@bors bors merged commit a1a3bf2 into rust-lang:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants