Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RLS and Rustfmt #49285

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Update RLS and Rustfmt #49285

merged 1 commit into from
Mar 23, 2018

Conversation

nrc
Copy link
Member

@nrc nrc commented Mar 22, 2018

Fixes broken RLS tests/build

r? @alexcrichton

@nrc
Update RLS and Rustfmt
aa238a3 
Fixes broken RLS tests/build
@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2018
@nrc
Copy link
Member Author

nrc commented Mar 22, 2018

cc @Mark-Simulacrum

@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Mar 22, 2018

📌 Commit aa238a3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2018
@kennytm
Copy link
Member

kennytm commented Mar 22, 2018

@bors p=10

@bors
Copy link
Contributor

bors commented Mar 23, 2018

⌛ Testing commit aa238a3 with merge aabed088ba7189c669a0d08453ebcf6435653552...

@Mark-Simulacrum
Copy link
Member

@bors retry - prioritize beta

@bors
Copy link
Contributor

bors commented Mar 23, 2018

⌛ Testing commit aa238a3 with merge 55e1104...

bors added a commit that referenced this pull request Mar 23, 2018
@bors
Auto merge of #49285 - nrc:update, r=alexcrichton
55e1104 
Update RLS and Rustfmt

Fixes broken RLS tests/build

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Mar 23, 2018

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 23, 2018
@alexcrichton
Copy link
Member

Tests passed and we need a fixed nightly, I'm going to merge this manually

@alexcrichton alexcrichton merged commit aa238a3 into rust-lang:master Mar 23, 2018
@kennytm-githubbot
Copy link

📣 Toolstate changed by #49285!

Tested on commit 55e1104.
Direct link to PR: #49285

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.

kennytm-githubbot added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Mar 23, 2018
@kennytm-githubbot
📣 Toolstate changed by rust-lang/rust#49285!
425610f 
Tested on commit rust-lang/rust@55e1104.
Direct link to PR: <rust-lang/rust#49285>

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
@bors bors mentioned this pull request Mar 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nrc @rust-highfive @alexcrichton @bors @kennytm @Mark-Simulacrum @kennytm-githubbot