Minor message/label formatting consistency fix. #49351
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
src/libstd/process.rs
Outdated
| @@ -5,7 +5,6 @@ | |||
| // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | |||
| // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | |||
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | |||
| // option. This file may not be copied, modified, or distributed | |||
There was a problem hiding this comment.
You accidentally deleted a line
| @@ -1444,7 +1443,7 @@ pub fn id() -> u32 { | |||
| #[unstable(feature = "termination_trait_lib", issue = "43301")] | |||
| #[rustc_on_unimplemented( | |||
| message="`main` has invalid return type `{Self}`", | |||
| label="`main` can only return types that implement {Termination}")] | |||
| label="`main` can only return types that implement `{Termination}`")] | |||
There was a problem hiding this comment.
Can you add a test that actually emits this message? Or find one and extend it with the entire message so this change is reflected in a test?
|
@oli-obk Both concerns you noted have been fixed. |
|
@bors r+ |
|
📌 Commit 9e6991c has been approved by |
bors
added
S-waiting-on-bors
Minor message/label formatting consistency fix. The unimplemented label for `Termination` was missing some backticks for consistency with the message.
|
☀️ Test successful - status-appveyor, status-travis |
The unimplemented label for
Terminationwas missing some backticks for consistency with the message.