Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #49426

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Update CONTRIBUTING.md #49426

merged 1 commit into from
Mar 28, 2018

Conversation

lukaslueg
Copy link
Contributor

The current link is a 404, just link to the main repo page

@lukaslueg
Update CONTRIBUTING.md
f513fbd 
The current link is a 404, just link to the main repo page
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2018
@kennytm
Copy link
Member

kennytm commented Mar 27, 2018

@bors r+ rollup

Thanks for spotting it!

@bors
Copy link
Contributor

bors commented Mar 27, 2018

📌 Commit f513fbd has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 27, 2018
@kennytm
Rollup merge of rust-lang#49426 - lukaslueg:patch-1, r=kennytm
605ea7c 
Update CONTRIBUTING.md

The current link is a 404, just link to the main repo page
@kennytm kennytm mentioned this pull request Mar 27, 2018
Merged
bors added a commit that referenced this pull request Mar 27, 2018
@bors
Auto merge of #49406 - kennytm:rollup, r=kennytm
35f368f 
Rollup of 11 pull requests

- Successful merges: #48639, #49223, #49333, #49369, #49381, #49395, #49399, #49401, #49417, #49202, #49426
- Failed merges:
bors added a commit that referenced this pull request Mar 28, 2018
@bors
Auto merge of #49406 - kennytm:rollup, r=kennytm
59ec9bf 
Rollup of 11 pull requests

- Successful merges: #48639, #49223, #49333, #49369, #49381, #49395, #49399, #49401, #49417, #49202, #49426
- Failed merges:
@bors bors merged commit f513fbd into rust-lang:master Mar 28, 2018
@lukaslueg lukaslueg deleted the patch-1 branch March 28, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukaslueg @rust-highfive @kennytm @bors @nikomatsakis