-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable target_feature on any LLVM 6+ #49428
Conversation
In `LLVMRustHasFeature()`, rather than using `MCInfo->getFeatureTable()` that is specific to Rust's LLVM fork, we can use this in LLVM 6: /// Check whether the subtarget features are enabled/disabled as per /// the provided string, ignoring all other features. bool checkFeatures(StringRef FS) const; Now rustc using external LLVM can also have `target_feature`.
(The bot seems to be asleep, so I've manually set the requested reviewer...) |
Does this mean we can drop rust-lang/llvm@a8a60a1? |
@rkruppe those tables are still used for |
(An alternative for that same info is |
Surely |
I think |
Ugh, that's news to me. IMO the |
📌 Commit a93a4d2 has been approved by |
…xcrichton Enable target_feature on any LLVM 6+ In `LLVMRustHasFeature()`, rather than using `MCInfo->getFeatureTable()` that is specific to Rust's LLVM fork, we can use this in LLVM 6: /// Check whether the subtarget features are enabled/disabled as per /// the provided string, ignoring all other features. bool checkFeatures(StringRef FS) const; Now rustc using external LLVM can also have `target_feature`. r? @alexcrichton
@rkruppe the problem is that |
In
LLVMRustHasFeature()
, rather than usingMCInfo->getFeatureTable()
that is specific to Rust's LLVM fork, we can use this in LLVM 6:
Now rustc using external LLVM can also have
target_feature
.r? @alexcrichton