Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize fetch_nand #49963

Merged
merged 1 commit into from
Apr 16, 2018
Merged

stabilize fetch_nand #49963

merged 1 commit into from
Apr 16, 2018

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Apr 14, 2018

This closes #13226 and makes Atomic*.fetch_nand stable.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2018
@@ -1555,7 +1554,7 @@ atomic_int! {
unstable(feature = "integer_atomics", issue = "32976"),
unstable(feature = "integer_atomics", issue = "32976"),
unstable(feature = "integer_atomics", issue = "32976"),
unstable(feature = "atomic_nand", issue = "13226"),
stable(feature = "atomic_nand", since = "1.27.0"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for AtomicU8 etc the method should remain unstable under the feature integer_atomics.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@kennytm
Copy link
Member

kennytm commented Apr 14, 2018

@bors r+

cc @rust-lang/libs. (FCP of this feature has already been completed).

@bors
Copy link
Contributor

bors commented Apr 14, 2018

📌 Commit c68c90a has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2018
@bors
Copy link
Contributor

bors commented Apr 16, 2018

⌛ Testing commit c68c90a with merge 532764c...

bors added a commit that referenced this pull request Apr 16, 2018
stabilize fetch_nand

This closes #13226 and makes `Atomic*.fetch_nand` stable.
@bors
Copy link
Contributor

bors commented Apr 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 532764c to master...

@bors bors merged commit c68c90a into rust-lang:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue: fetch_nand
4 participants