-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only emit save-analysis data for cargo build
tasks
#50022
Conversation
Previously, we were emittinng analysis data for all tasks, including `doc`. That meant we got two sets of save-analysis data, one from the normal build and one from the docs. That means indexing with the RLS took twice as long and made downloads larger and build times longer. cc rust-lang/rls#826
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Note the test failure was for an earlier commit that I force-pushed over, currently passing Travis. |
Seems fine to me; just to check though this shouldn't cause problems for doxidize or the like, correct? That is, despite them wanting to run in If that's not a concern, r=me. |
@Mark-Simulacrum this only affects Rust build, so it shouldn't affect Doxidize. We would need to expand the check to @bors: r=mark-simulacrum |
📌 Commit de34735 has been approved by |
Only emit save-analysis data for `cargo build` tasks Previously, we were emittinng analysis data for all tasks, including `doc`. That meant we got two sets of save-analysis data, one from the normal build and one from the docs. That means indexing with the RLS took twice as long and made downloads larger and build times longer. cc rust-lang/rls#826 r? @Mark-Simulacrum
☀️ Test successful - status-appveyor, status-travis |
Previously, we were emittinng analysis data for all tasks, including
doc
. That meant we got two sets of save-analysis data, one from the normal build and one from the docs. That means indexing with the RLS took twice as long and made downloads larger and build times longer.cc rust-lang/rls#826
r? @Mark-Simulacrum