Tweak some stabilizations in libstd #50088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler |
alexcrichton
added
beta-nominated
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This commit tweaks a few stable APIs in the `beta` branch before they hit stable. The `str::is_whitespace` and `str::is_alphanumeric` functions were deleted (added in rust-lang#49381, issue at rust-lang#49657). The `and_modify` APIs added in rust-lang#44734 were altered to take a `FnOnce` closure rather than a `FnMut` closure. Closes rust-lang#49581 Closes rust-lang#49657
alexcrichton
force-pushed
the
std-tweaks
branch
from
743ed79
to
ca79ba3
Compare
sfackler
reviewed
Apr 20, 2018
| /// ``` | ||
| #[stable(feature = "unicode_methods_on_intrinsics", since = "1.27.0")] | ||
| #[inline] | ||
| pub fn is_whitespace(&self) -> bool { |
There was a problem hiding this comment.
Should we be destabilizing and deprecating these for a bit? Not sure if they've been around and unstable previously.
There was a problem hiding this comment.
I'd be ok with that as well yeah, or perhaps just reverting these to unstable? I'm fine either way, they were added insta-stable in #49381 and haven't been around for all that long so I don't think we need too too much process
There was a problem hiding this comment.
Oh cool if they're new then it seems fine to just remove.
pietroalbini
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit ca79ba3 has been approved by |
bors
added
S-waiting-on-bors
|
@bors: p=1 (as this is beta-nominated) |
bors
added a commit
that referenced
this pull request
Apr 20, 2018
Tweak some stabilizations in libstd This commit tweaks a few stable APIs in the `beta` branch before they hit stable. The `str::is_whitespace` and `str::is_alphanumeric` functions were deleted (added in #49381, issue at #49657). The `and_modify` APIs added in #44734 were altered to take a `FnOnce` closure rather than a `FnMut` closure. Closes #49581 Closes #49657
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Apr 21, 2018
[beta] Tweak some stabilizations in libstd This is a backport of #50088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tweaks a few stable APIs in the
betabranch before they hitstable. The
str::is_whitespaceandstr::is_alphanumericfunctions weredeleted (added in #49381, issue at #49657). The
and_modifyAPIs addedin #44734 were altered to take a
FnOnceclosure rather than aFnMutclosure.Closes #49581
Closes #49657