Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #50245

Merged
merged 8 commits into from
Apr 26, 2018
Merged

Rollup of 4 pull requests #50245

merged 8 commits into from
Apr 26, 2018

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

Failed merges:

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2018
@GuillaumeGomez
Copy link
Member Author

(Damn, one failed...)

@bors: r+ p=4

@bors
Copy link
Contributor

bors commented Apr 26, 2018

📌 Commit 438f3ca has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2018
@bors
Copy link
Contributor

bors commented Apr 26, 2018

⌛ Testing commit 438f3ca with merge 88cd367...

bors added a commit that referenced this pull request Apr 26, 2018
Rollup of 4 pull requests

Successful merges:

 - #50177 (mark std::str::replace(,n) as #[must_use])
 - #50207 (Hash EntryKind::AssociatedConst const data)
 - #50214 (Js improvements)
 - #50219 (Added missing `.` in docs.)

Failed merges:

 - #50229 (Add setting to go to item if there is only one result)
@bors
Copy link
Contributor

bors commented Apr 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 88cd367 to master...

@bors bors merged commit 438f3ca into rust-lang:master Apr 26, 2018
@GuillaumeGomez GuillaumeGomez deleted the rollup branch April 26, 2018 14:26
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants