mark most of std::str methods as #[must_use] #50479
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have recently noticed #50117 and realized that most of the methods in
std::str
should be annotated with#[must_use]
. I have even accidentally noticed a wrong use of.to_lowercase()
in one of a recent Reddit answers, which proves that it is worthwhile to warn users about incorrect usage.P.S. It seems that there is a need to annotate quite a lot of functions. Is there a plan to do that?