Add From<bool> for int types #50554

clarfonthey · 2018-05-09T01:37:42Z

rust-highfive · 2018-05-09T01:37:53Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-05-09T02:52:00Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:11:39]    Compiling core v0.0.0 (file:///checkout/src/libcore)
[01:11:53] error[E0282]: type annotations needed
[01:11:53]    --> libcore/../libcore/tests/result.rs:223:19
[01:11:53]     |
[01:11:53] 223 |         let val = Ok(1)?;
[01:11:53]     |                   ^^^^^^ cannot infer type for `_`
[01:11:54] error: aborting due to previous error
[01:11:54] 
[01:11:54] For more information about this error, try `rustc --explain E0282`.
[01:11:54] error: Could not compile `core`.
[01:11:54] error: Could not compile `core`.
[01:11:54] 
[01:11:54] To learn more, run the command again with --verbose.
[01:11:54] 
[01:11:54] 
[01:11:54] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
[01:11:54] 
[01:11:54] 
[01:11:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:11:54] Build completed unsuccessfully in 0:28:38
[01:11:54] Build completed unsuccessfully in 0:28:38
[01:11:54] Makefile:58: recipe for target 'check' failed
[01:11:54] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0ebdfa38
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

clarfonthey · 2018-05-09T05:12:49Z

Actually, apparently this causes inference issues. That should probably be investigated before this is merged.

KamilaBorowska

fn try_result_ok() -> Result<u8, u8> {
    let val = Ok(1)?;
    Ok(val)
}

Ok(x)? for Result<_, u8> (as well as variations like return Err(u8::from(unimplemented!()));) sound like an edge case for me - I don't think realistically anyone would write code like this. This can be written as x, and I think this inference failure is not a practical issue. The test here could be changed to use a type other than u8, for example fn try_result_ok() -> Result<u8, bool>.

Additionally, according to https://github.com/rust-lang/rfcs/blob/master/text/1105-api-evolution.md, this would be a minor change.

TimNN · 2018-05-14T05:53:27Z

cc @rust-lang/libs: This has the potential to be inference-breaking. What do you think? Does this need a crater run?

therealprof · 2018-05-14T17:38:11Z

@SimonSapin The motivation for this is automatically generated code by svd2rust. Ideally we would like to use From for all types but that doesn't work for bool so we have to use as instead which generates a lot of noise. There alternative would be to special case per type which is also not desirable.

clarfonthey · 2018-05-14T17:41:00Z

Also, the main purpose of the lint is that in general, From should be used when the conversion is lossless, as as allows lossy conversions. This helps in macros and other places to ensure that only lossless conversions occur.

alexcrichton · 2018-05-14T21:49:47Z

Yeah I think it wouldn't hurt to get a crater run for this.

cc @rust-lang/infra, mind scheduling a crater run here?

kennytm · 2018-05-14T22:01:11Z

@bors try

bors · 2018-05-14T22:01:23Z

⌛ Trying commit a882197034b9b3eafb5e35c3f010d21fca0e0df4 with merge 4b647638d12b7679c1eee120c4c064bc749eb782...

bors · 2018-05-14T23:52:56Z

☀️ Test successful - status-travis
State: approved= try=True

Mark-Simulacrum · 2018-05-17T01:43:24Z

Check-only crater run started.

pietroalbini · 2018-05-19T07:50:21Z

Hi @alexcrichton (crater requester), @TimNN (PR reviewer)! Crater results are at: http://cargobomb-reports.s3.amazonaws.com/pr-50554/index.html. 'Blacklisted' crates (spurious failures etc) can be found here. If you see any spurious failures not on the list, please make a PR against that file.

(interested observers: Crater is a tool for testing the impact of changes on the crates.io ecosystem. You can find out more at the repo if you're curious)

pietroalbini · 2018-05-19T07:53:01Z

And both of the regressions are spurious \o/.

TimNN · 2018-05-19T08:05:00Z

This looks good to go, @clarcharr can you fix the travis failure?

~~Also cc @rust-lang/libs, I will approve this unless you have any objections.~~ I overlooked that since the impls are insta-stable this should go through an FCP.

scottmcm · 2018-05-19T13:56:55Z

Since adding impls is a stabilization, doesn't this need an FCP?

clarfonthey · 2018-05-19T15:29:31Z

@TimNN Will do! Although I agree with @scottmcm that this needs an FCP.

bors · 2018-05-30T22:59:11Z

🔒 Merge conflict

rfcbot · 2018-05-31T17:52:07Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

clarfonthey · 2018-06-01T21:47:34Z

I rebased but there weren't actually any merge conflicts.

TimNN · 2018-06-02T03:22:13Z

@bors r+

bors · 2018-06-02T03:22:13Z

📌 Commit b1797d5 has been approved by TimNN

bors · 2018-06-02T05:15:37Z

⌛ Testing commit b1797d5 with merge 4a9bf7c...

Add From<bool> for int types Fixes #46109.

bors · 2018-06-02T06:32:08Z

💔 Test failed - status-travis

rust-highfive · 2018-06-02T06:32:10Z

The job dist-x86_64-netbsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

  0     0    0     0    0     0      0      0 --:--:--  0:00:15 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:16 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:17 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:18 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:19 --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:13:28] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:575:17
[01:13:28] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-netbsd --target x86_64-unknown-netbsd
[01:13:28] Build completed unsuccessfully in 1:09:53
travis_time:end:08518c12:start=1527916642471126256,finish=1527921051331467157,duration=4408860340901

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-02T06:32:18Z

The job dist-x86_64-netbsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

  0     0    0     0    0     0      0      0 --:--:--  0:00:15 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:16 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:17 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:18 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:19 --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:13:28] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:575:17
[01:13:28] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-netbsd --target x86_64-unknown-netbsd
[01:13:28] Build completed unsuccessfully in 1:09:53
travis_time:end:08518c12:start=1527916642471126256,finish=1527921051331467157,duration=4408860340901

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-06-02T06:49:47Z

@bors retry #40474

bors · 2018-06-02T07:50:16Z

⌛ Testing commit b1797d5 with merge 2954cb5...

Add From<bool> for int types Fixes #46109.

bors · 2018-06-02T09:58:32Z

☀️ Test successful - status-appveyor, status-travis
Approved by: TimNN
Pushing 2954cb5 to master...

rust-highfive assigned TimNN May 9, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2018

KamilaBorowska reviewed May 9, 2018

View reviewed changes

KamilaBorowska approved these changes May 9, 2018

View reviewed changes

scottmcm mentioned this pull request May 10, 2018

Add TryFrom<{integer}> for bool #50597

Closed

This comment has been minimized.

Sign in to view

alexcrichton added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label May 14, 2018

TimNN removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2018

pietroalbini added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 19, 2018

TimNN added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2018

kennytm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 19, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 30, 2018

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 31, 2018

clarfonthey added 3 commits June 1, 2018 17:46

Add From<bool> for int types

8c3bdcc

Fix ambiguity in Result test

7fe56e8

Add @ithinuel's tests from rust-lang#50597

b1797d5

clarfonthey force-pushed the from_bool branch from 4f49c21 to b1797d5 Compare June 1, 2018 21:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2018

bors added a commit that referenced this pull request Jun 2, 2018

Auto merge of #50554 - clarcharr:from_bool, r=TimNN

4a9bf7c

Add From<bool> for int types Fixes #46109.

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2018

bors added a commit that referenced this pull request Jun 2, 2018

Auto merge of #50554 - clarcharr:from_bool, r=TimNN

2954cb5

Add From<bool> for int types Fixes #46109.

bors merged commit b1797d5 into rust-lang:master Jun 2, 2018

clarfonthey deleted the from_bool branch June 22, 2018 20:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add From<bool> for int types #50554

Add From<bool> for int types #50554

clarfonthey commented May 9, 2018

rust-highfive commented May 9, 2018

rust-highfive commented May 9, 2018

clarfonthey commented May 9, 2018

KamilaBorowska left a comment •

edited

Loading

TimNN commented May 14, 2018

This comment has been minimized.

therealprof commented May 14, 2018

clarfonthey commented May 14, 2018

alexcrichton commented May 14, 2018

kennytm commented May 14, 2018

bors commented May 14, 2018

bors commented May 14, 2018

Mark-Simulacrum commented May 17, 2018

pietroalbini commented May 19, 2018

pietroalbini commented May 19, 2018

TimNN commented May 19, 2018 •

edited

Loading

scottmcm commented May 19, 2018

clarfonthey commented May 19, 2018

bors commented May 30, 2018

rfcbot commented May 31, 2018

clarfonthey commented Jun 1, 2018

TimNN commented Jun 2, 2018

bors commented Jun 2, 2018

bors commented Jun 2, 2018

bors commented Jun 2, 2018

rust-highfive commented Jun 2, 2018

rust-highfive commented Jun 2, 2018

kennytm commented Jun 2, 2018

bors commented Jun 2, 2018

bors commented Jun 2, 2018

Add From<bool> for int types #50554

Add From<bool> for int types #50554

Conversation

clarfonthey commented May 9, 2018

rust-highfive commented May 9, 2018

rust-highfive commented May 9, 2018

clarfonthey commented May 9, 2018

KamilaBorowska left a comment • edited Loading

Choose a reason for hiding this comment

TimNN commented May 14, 2018

This comment has been minimized.

therealprof commented May 14, 2018

clarfonthey commented May 14, 2018

alexcrichton commented May 14, 2018

kennytm commented May 14, 2018

bors commented May 14, 2018

bors commented May 14, 2018

Mark-Simulacrum commented May 17, 2018

pietroalbini commented May 19, 2018

pietroalbini commented May 19, 2018

TimNN commented May 19, 2018 • edited Loading

scottmcm commented May 19, 2018

clarfonthey commented May 19, 2018

bors commented May 30, 2018

rfcbot commented May 31, 2018

clarfonthey commented Jun 1, 2018

TimNN commented Jun 2, 2018

bors commented Jun 2, 2018

bors commented Jun 2, 2018

bors commented Jun 2, 2018

rust-highfive commented Jun 2, 2018

rust-highfive commented Jun 2, 2018

kennytm commented Jun 2, 2018

bors commented Jun 2, 2018

bors commented Jun 2, 2018

KamilaBorowska left a comment •

edited

Loading

TimNN commented May 19, 2018 •

edited

Loading