Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros have scope #5120

Closed
wants to merge 6 commits into from
Closed

Conversation

jbclements
Copy link
Contributor

r?

After this patch, macros declared in a module, function, or block can only be used inside of that module, function or block, with the exception of modules declared with the #[macro_escape] attribute; these modules allow macros to escape, and can be used as a limited macro export mechanism.

This pull request also includes miscellaneous comments, lots of new test cases, a few renamings, and a few as-yet-unused data definitions for hygiene.

@jbclements
Copy link
Contributor Author

I believe this commit should close issues #4906 and #3114.

macro_rules! without_macro_scoping(
($extsexpr:expr,$exp:expr) =>
({
// only evaluaate this once:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "evaluate"

@jbclements
Copy link
Contributor Author

r? @pcwalton : typo fixes, renamings

bors added a commit that referenced this pull request Feb 27, 2013
r?

After this patch, macros declared in a module, function, or block can only be used inside of that module, function or block, with the exception of modules declared with the #[macro_escape] attribute; these modules allow macros to escape, and can be used as a limited macro export mechanism.

This pull request also includes miscellaneous comments, lots of new test cases, a few renamings, and a few as-yet-unused data definitions for hygiene.
@bors bors closed this Feb 27, 2013
@pnkfelix pnkfelix mentioned this pull request May 7, 2013
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2020
…flip1995

Split up `drop_forget_ref` ui test

Part of rust-lang#2038

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants