Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate / export weak lang items #51687

Merged
merged 2 commits into from
Jun 28, 2018
Merged

translate / export weak lang items #51687

merged 2 commits into from
Jun 28, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented Jun 21, 2018

see #51671 for details

fixes #51671
fixes #51342

r? @michaelwoerister or @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2018
@japaric japaric mentioned this pull request Jun 21, 2018
Closed
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 

[00:04:47] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:48] tidy error: /checkout/src/test/run-make-fulldeps/issue-51671/app.rs: incorrect license
[00:04:49] some tidy checks failed
[00:04:49] 
[00:04:49] 
[00:04:49] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:49] 
[00:04:49] 
[00:04:49] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:49] Build completed unsuccessfully in 0:01:44
[00:04:49] Build completed unsuccessfully in 0:01:44
[00:04:49] Makefile:79: recipe for target 'tidy' failed
[00:04:49] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1eed1000
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:24f472dd:start=1529604655958727064,finish=1529604655966101255,duration=7374191
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:16ee8967
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:07260aeb
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@pietroalbini pietroalbini added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 28, 2018

📌 Commit cce7007 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2018
@bors
Copy link
Contributor

bors commented Jun 28, 2018

⌛ Testing commit cce7007 with merge e3bf634...

bors added a commit that referenced this pull request Jun 28, 2018
@bors
Auto merge of #51687 - japaric:gh51671, r=alexcrichton
e3bf634 
translate / export weak lang items

see #51671 for details

fixes #51671
fixes #51342

r? @michaelwoerister or @alexcrichton
@bors
Copy link
Contributor

bors commented Jun 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing e3bf634 to master...

@bors bors merged commit cce7007 into rust-lang:master Jun 28, 2018
phil-opp added a commit to phil-opp/blog_os that referenced this pull request Jul 1, 2018
@phil-opp
Public and no_mangle is no longer needed
3646bcb 
Fixed in rust-lang/rust#51687
phil-opp added a commit to phil-opp/blog_os that referenced this pull request Jul 9, 2018
@phil-opp
Public and no_mangle is no longer needed
8a4d9fd 
Fixed in rust-lang/rust#51687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rust_begin_unwind not emitted when crate-type = bin panic_implementation: no_mangle attribute needed?
6 participants
@japaric @rust-highfive @alexcrichton @bors @michaelwoerister @pietroalbini