Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A fix for 51821 #51855

Merged
merged 10 commits into from
Jul 1, 2018
Merged

A fix for 51821 #51855

merged 10 commits into from
Jul 1, 2018

Commits on Jun 28, 2018

  1. Remove duplicates

    @Eh2406
    Eh2406 committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    8a35601 View commit details
    Browse the repository at this point in the history

  2. use retain to avoid the allocation

    @Eh2406
    Eh2406 committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    0119669 View commit details
    Browse the repository at this point in the history

  3. use the type system to ensure we dedup from the start

    @Eh2406
    Eh2406 committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    e4f0368 View commit details
    Browse the repository at this point in the history

  4. move related types into the new module

    @Eh2406
    Eh2406 committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    e2c0378 View commit details
    Browse the repository at this point in the history

  5. fix typo and tidy

    @Eh2406
    Eh2406 committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    497a3b4 View commit details
    Browse the repository at this point in the history

  6. remove inner_mut as it can mess up invariants

    @Eh2406
    Eh2406 committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    9bd2a63 View commit details
    Browse the repository at this point in the history

  7. each_affected_by_dirty

    @Eh2406
    Eh2406 committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    4b44db1 View commit details
    Browse the repository at this point in the history

  8. use deref instead of inner

    @Eh2406
    Eh2406 committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    ad71cbf View commit details
    Browse the repository at this point in the history

  9. add comments

    @Eh2406
    Eh2406 committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    6e0cefe View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2018

  1. remove the FxHashSet since it's not helping us in practice 

    It turns out that we don't have duplicates, just self-cycles.
    @nikomatsakis
    nikomatsakis committed Jul 1, 2018
    Configuration menu
    Copy the full SHA
    ac5bd5d View commit details
    Browse the repository at this point in the history