Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NLL] Small move error reporting improvements #52359

Merged
merged 4 commits into from
Jul 22, 2018
Merged

[NLL] Small move error reporting improvements #52359

merged 4 commits into from
Jul 22, 2018

Conversation

matthewjasper
Copy link
Contributor

@matthewjasper matthewjasper commented Jul 13, 2018 •
edited
Loading

  • Use a MirBorrowckContext when reporting errors to be more uniform with other error reporting
  • Add a special message for the case of trying to move from capture variables in Fn and FnMut closures.

part of #51028

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2018
@matthewjasper
Copy link
Contributor Author

r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned eddyb Jul 13, 2018
@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 17, 2018

📌 Commit d1acee6ed179b568d62c55bbce960782386188b2 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2018
@bors
Copy link
Contributor

bors commented Jul 18, 2018

⌛ Testing commit d1acee6ed179b568d62c55bbce960782386188b2 with merge 94074eada69e5a6390c1e4c8bbe5080e46693a9f...

@bors
Copy link
Contributor

bors commented Jul 18, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2018
@kennytm
Copy link
Member

kennytm commented Jul 18, 2018 

---- [ui (nll)] ui\issue-30355.rs stdout ----
diff of stderr:
-	error[E0508]: cannot move out of type `[u8]`, a non-copy slice
-	  --> $DIR/issue-30355.rs:15:8
-	   |
-	LL |     &X(*Y)
-	   |        ^^ cannot move out of here
-	
7	error[E0161]: cannot move a value of type X: the size of X cannot be statically determined
8	  --> $DIR/issue-30355.rs:15:6
9	   |
15	   |
16	LL |     &X(*Y)
17	   |        ^^
+	
+	error[E0508]: cannot move out of type `[u8]`, a non-copy slice
+	  --> $DIR/issue-30355.rs:15:8
+	   |
+	LL |     &X(*Y)
+	   |        ^^ cannot move out of here
18	
19	error: aborting due to 3 previous errors
20

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2018
@matthewjasper
Copy link
Contributor Author

Tests updated

@kennytm
Copy link
Member

kennytm commented Jul 18, 2018

@bors r=pnkfelix

@bors
Copy link
Contributor

bors commented Jul 18, 2018

📌 Commit 29bbb1264e2fcf579d363fdff84d8a69d9261c4b has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2018
@euclio
Copy link
Contributor

euclio commented Jul 19, 2018

I realize this PR's already been approved, but if there's still time, it would be worth removing this line (merged in #52197), since this PR fixes the ICE in that test.

@matthewjasper
Copy link
Contributor Author

Done, needs another r+.

@bors
Copy link
Contributor

bors commented Jul 21, 2018

☔ The latest upstream changes (presumably #52405) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2018
@Mark-Simulacrum
Copy link
Member

@bors r=pnkfelix

@bors
Copy link
Contributor

bors commented Jul 21, 2018

📌 Commit d34924d has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2018
@bors
Copy link
Contributor

bors commented Jul 22, 2018

⌛ Testing commit d34924d with merge 742e09cdd5516bad425f81372bbcaa9582434ae7...

@bors
Copy link
Contributor

bors commented Jul 22, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Jul 22, 2018

@bors retry travis-ci/travis-ci#9696

[01:51:58] fatal: unable to access 'https://github.com/dzamlo/treeify/': Could not resolve host: github.com

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2018
@bors
Copy link
Contributor

bors commented Jul 22, 2018

⌛ Testing commit d34924d with merge aeca042...

bors added a commit that referenced this pull request Jul 22, 2018
@bors
Auto merge of #52359 - matthewjasper:combine-move-error-reporting, r=…
aeca042 
…pnkfelix

[NLL] Small move error reporting improvements

* Use a MirBorrowckContext when reporting errors to be more uniform with other error reporting
* Add a special message for the case of trying to move from capture variables in `Fn` and `FnMut` closures.

part of #51028
@bors
Copy link
Contributor

bors commented Jul 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing aeca042 to master...

@bors bors merged commit d34924d into rust-lang:master Jul 22, 2018
@bors bors mentioned this pull request Jul 22, 2018
Merged
@matthewjasper matthewjasper deleted the combine-move-error-reporting branch September 3, 2018 21:32
@pnkfelix pnkfelix mentioned this pull request Oct 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@matthewjasper @rust-highfive @pnkfelix @bors @kennytm @euclio @Mark-Simulacrum @eddyb