Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an appveyor config for aarch64-pc-windows-msvc #54718

Merged
merged 2 commits into from
Nov 2, 2018

Conversation

froydnj
Copy link
Contributor

@froydnj froydnj commented Oct 1, 2018

This is purely a cargo-cult of things to solicit feedback from humans and/or automation failures. Not sure that the build artifacts would get packaged properly to start providing nightly tarballs for libstd, but this is at least a start.

Fixes #53864.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2018
@alexcrichton
Copy link
Member

Thanks! We've currently maxed out our parallelism with AppVeyor which means we can't easily add another entry to the job matrix at the moment. (as it'd take another 2 hours beyond the initial two hours). Our hard time limit is 3 hours per job but we tend to shoot for 2 hours max per job. Building a standard library, however, is pretty cheap so we can try to slot it in with an existing build!

Looking at a recent successful build it looks like the job that builds the i586 msvc target has 30 extra minutes, so mind slotting it in there with an extra --target argument?

@froydnj
Copy link
Contributor Author

froydnj commented Oct 1, 2018

Thanks for the explanation!

Looking at a recent successful build it looks like the job that builds the i586 msvc target has 30 extra minutes, so mind slotting it in there with an extra --target argument?

I can try! I'm not sure how the "cross-compile 64-bit target on 32-bit platform" is going to go, but MSVC appears to support it, so we'll try it. Is it possible to trigger an appveyor run (ideally just the build being modified) for the changes?

@alexcrichton
Copy link
Member

@bors: r+

Alright let's see how this goes!

@bors
Copy link
Contributor

bors commented Oct 1, 2018

📌 Commit 215c649917797ebc276b220883c6f941c2b8cef0 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2018
@bors
Copy link
Contributor

bors commented Oct 3, 2018

⌛ Testing commit 215c649917797ebc276b220883c6f941c2b8cef0 with merge b01953bf4fe77973d7759e0d14d6e4362bf1127e...

@bors
Copy link
Contributor

bors commented Oct 3, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 3, 2018
@froydnj
Copy link
Contributor Author

froydnj commented Oct 3, 2018

configure: processing command line
configure: 
configure: rust.dist-src        := False
configure: llvm.clang-cl        := C:\clang-rust\bin\clang-cl.exe
configure: build.print-step-timings := True
configure: rust.remap-debuginfo := True
configure: error: Option 'target' provided more than once
Command exited with code 1

Well, that didn't go as planned!

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2018
@alexcrichton
Copy link
Member

Ah right I think the targets need to be comma separated in one argument, my bad!

@froydnj
Copy link
Contributor Author

froydnj commented Oct 3, 2018

Ah right I think the targets need to be comma separated in one argument, my bad!

No problem, let's try this again!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 3, 2018

📌 Commit 6d2fd35432bdda56df761d2c98b94bf3e3fc2122 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 3, 2018
@bors
Copy link
Contributor

bors commented Oct 5, 2018

⌛ Testing commit 6d2fd35432bdda56df761d2c98b94bf3e3fc2122 with merge aca87cdaf6312156fe9ff996af470828e3611de0...

@bors
Copy link
Contributor

bors commented Oct 5, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 5, 2018
@froydnj
Copy link
Contributor Author

froydnj commented Oct 31, 2018

3 hour timeout in dist-i686-msvc.

This is probably an actual problem, since we're adding more work to the dist-i686-msvc job. Apparently it's not as cheap as expected to build just a stdlib?

@kennytm
Copy link
Member

kennytm commented Oct 31, 2018

Ah okay. Could we add the target to dist-x86_64-msvc instead?

@froydnj
Copy link
Contributor Author

froydnj commented Oct 31, 2018

Ah okay. Could we add the target to dist-x86_64-msvc instead?

We could try! The timings Alex referenced above suggest that there's slightly more headroom in the dist-x86_64-msvc job, and maybe building a 64-bit stdlib on a 64-bit host will lead to better results anyway?

This version ought to work better with MSVC 15.9 preview headers.
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 31, 2018
@alexcrichton
Copy link
Member

@bors: r+

Nah I think this is fine still or rather it is "probably fine". By updating Clang it busted all the sccache caches, which can often cause us to overflow the time limit. The caches should be primed now, so let's see if it works this time!

@bors
Copy link
Contributor

bors commented Oct 31, 2018

📌 Commit ebf6507 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2018
@froydnj
Copy link
Contributor Author

froydnj commented Oct 31, 2018

By updating Clang it busted all the sccache caches, which can often cause us to overflow the time limit. The caches should be primed now, so let's see if it works this time!

Ah, good point, I didn't think about that!

@bors
Copy link
Contributor

bors commented Oct 31, 2018

⌛ Testing commit ebf6507 with merge d458ce5e099ba1dfd4ebb38410a8c7a10f713415...

@bors
Copy link
Contributor

bors commented Oct 31, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 31, 2018
@kennytm
Copy link
Member

kennytm commented Oct 31, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2018
@bors
Copy link
Contributor

bors commented Nov 2, 2018

⌛ Testing commit ebf6507 with merge d0c869c...

bors added a commit that referenced this pull request Nov 2, 2018
add an appveyor config for aarch64-pc-windows-msvc

This is purely a cargo-cult of things to solicit feedback from humans and/or automation failures.  Not sure that the build artifacts would get packaged properly to start providing nightly tarballs for `libstd`, but this is at least a start.

Fixes #53864.
@bors
Copy link
Contributor

bors commented Nov 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing d0c869c to master...

@bors bors merged commit ebf6507 into rust-lang:master Nov 2, 2018
@alexcrichton
Copy link
Member

The timing of this looks good to me, the builder for this PR with aarch64 came in at just around 2 hours, which is perfect!

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 5, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Nov 7, 2018
…ichaelwoerister

Add `aarch64-pc-windows-msvc` to deployed targets

Accidentally forgotten from rust-lang#54718!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants