Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

second round of refactorings for universes #54858

Merged
merged 12 commits into from
Oct 15, 2018
Merged

second round of refactorings for universes #54858

merged 12 commits into from
Oct 15, 2018

Commits on Oct 15, 2018

  1. canonicalizer.rs: rustfmt

    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    110b3b9 View commit details
    Browse the repository at this point in the history

  2. bundle up "canonical instantiation" with infcx creation

    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    fd046a2 View commit details
    Browse the repository at this point in the history

  3. rename QueryResult to QueryResponse 

    `Result` really sounds like the rustc result type
    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    bca294d View commit details
    Browse the repository at this point in the history

  4. type_op/mod.rs: rustfmt

    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    71caf8a View commit details
    Browse the repository at this point in the history

  5. introduce canonical_var_for_region helper fn

    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    42a6618 View commit details
    Browse the repository at this point in the history

  6. control canonicalization with a trait vs bools

    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    28df2bf View commit details
    Browse the repository at this point in the history

  7. make UniverseIndex hashable, rename "sub-" to "superuniverse" 

    The only name was silly. U1 can contain everything from U0 *plus* more
things.
    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    460915b View commit details
    Browse the repository at this point in the history

  8. convert UniverseIndex into a newtype_index!

    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    da76b4d View commit details
    Browse the repository at this point in the history

  9. hide SmallCanonicalVarValues in OriginalQueryValues struct

    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    6ace43c View commit details
    Browse the repository at this point in the history

  10. remove dead iterator code

    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    be02f74 View commit details
    Browse the repository at this point in the history

  11. pacify the mercilous tidy with rustfmt

    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    f419077 View commit details
    Browse the repository at this point in the history

  12. remove the sub/super terminology for universes 

    Instead, we talk about:

- creating the "next" universe
- universes "extending" one another
- and `u1.can_name(u2)`, meaning that `u1` contains all names from `u2`
    @nikomatsakis
    nikomatsakis committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    05f67ca View commit details
    Browse the repository at this point in the history